This module adds a custom uc_payflowpro_payment_action variable to determine whether to perform an Authorization for a Sale. Ubercart comes with built-in transaction types that are added to every payment gateway that is implemented. This leaves one confused on the settings page since both options are present.

Cheers,

Antoine

CommentFileSizeAuthor
#1 uc_payflowpro-1012348.patch3.92 KBjantoine
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jantoine’s picture

jantoine CreditAttribution: jantoine commented
Status: Active » Needs review
FileSize
uc_payflowpro-1012348.patch3.92 KB

A patch is attached with an update function that copies the value from the uc_payflowpro_payment_action variable to the built-in uc_pg_payflowpro_cc_txn_type variable.

Cheers,

Antoine

kwinters’s picture

kwinters CreditAttribution: kwinters commented

Thanks for the patch!

I don't have time for a full review at the moment, but a quick look seems pretty reasonable. I'll go over it in detail when I get the chance.

torgosPizza’s picture

torgosPizza
he/him
Primary language English
Location Portland, OR
CreditAttribution: torgosPizza commented

Any progress on review for this patch? I can help test soon.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Status: Needs review » Needs work

A version of the patch that works after #1661716: Code in uc_payflowpro_form_alter() causes checkout to fail (patch #22) is applied would be really useful.