Rooms already in cart still display in search results

Can they checkout?
There is a hook_order or similar in the code that is supposed to prevent them from finishing checkout.

Lee

What paypal module are you using - wps or express?
WPS definitely generates the order first so if you're using that - it's definitely not working the way it should.

The right way to do this is to prevent checkout, not adding to cart.
Otherwise your competitor could go to your site, add all of your rooms to their cart and then leave them there - and noone else could book.

Hi
To be honest I don't have time to look at this at the moment.
It should be an implementation of hook_order (see the Ubercart api docs on the Ubercart site) that does a final 'pre-flight' check and prevents the order from continuing if necessary.

LR

Hi Lee, Our issue was closed as a duplicate, we are on vers 2.dev not 4. we are also being held back from going live by this problem, it would appear that there is already a check in place, but it avoids adding the SAME search to the cart and only the same search. Are we sure that this is the same issue? in both versions of the code?
Franco

Hi Lee,

I realize you are very busy and your last post here was almost a month ago... Would it be possible to hire you to solve this problem? We were supposed to go live on October first and our client is unhappy because we have not fixed this problem yet. Please let me know...

The cart allows you to add the same room for overlapping dates twice (in the same transaction), thereby double booking the room. The Room Availability sets itself to -1. Also, I was emailed two booking confirmations, both with the same information in each. I am NOT saying rooms are double booked in separate transactions, just within the same transaction.
However, it does NOT allow a double booking in the cart if you book the exact same room with all the same criteria (date, number of people, number of nights).
In other words....
If you simply book the same room twice without changing dates or number of nights, it overwrites what was in the cart without double booking the room correctly.
BUT if you change the number of nights but leave the same date it lets you add the room to the cart and double books.
Also, if you change the number of people in the room but leave the same dates it lets you double book the room.

Regards, Heidi

ooops! I changed the version from the original post but I just changed it back... sorry

Hi Lee,

I realize you are very busy and your last post here was almost a month ago... Would it be possible to hire you to solve this problem? We were supposed to go live on October first and our client is unhappy because we have not fixed this problem yet. Please let me know...

The cart allows you to add the same room for overlapping dates twice (in the same transaction), thereby double booking the room. The Room Availability sets itself to -1. Also, I was emailed two booking confirmations, both with the same information in each. I am NOT saying rooms are double booked in separate transactions, just within the same transaction.
However, it does NOT allow a double booking in the cart if you book the exact same room with all the same criteria (date, number of people, number of nights).
In other words....
If you simply book the same room twice without changing dates or number of nights, it overwrites what was in the cart without double booking the room correctly.
BUT if you change the number of nights but leave the same date it lets you add the room to the cart and double books.
Also, if you change the number of people in the room but leave the same dates it lets you double book the room.

Regards, Heidi

Hi there, do you know how to implement this?

"It should be an implementation of hook_order (see the Ubercart api docs on the Ubercart site) that does a final 'pre-flight' check and prevents the order from continuing if necessary."

ty, H

I knew I'd done this at some stage...
This is from pre v1 of the module so tables names etc have change but it's a good start:
Other issues:
a) not i18n friendly
b) $product->title is not passed through check_plain
c) doesn't meet coding standards
This dates back to my first ever drupal code (and it shows)
Lee

/**
* Implementation of hook_order
*/
function hotel_booking_order($op, &$order, $status) {
    switch($op) {
    case 'load':
        foreach($order->products as $key => $product){
            if($product->data['module'] = 'hotel_booking'){
                //this is a hotel booking product
                //check still available
                $nid = $product->nid;
                $nights = $product->data['nights'];
                if(is_array($nights)) {
                    foreach($nights as $night) {
                        foreach($nights as $night) {
                            //do it like this in case cart has two products the same with same dates
                            $allNights[$night]++;
                        }
                        foreach($allNights as $night => $qty) {
                            $result = db_query("SELECT avail_quantity
                                               FROM {hotel_availability_calendars}
                                               WHERE rtid = %d
                                               AND caldate = '%s'", $nid, $night);
                            $avail = db_result($result);
                            if($avail < $qty) {
                                return array(array('pass' => FALSE, 'message' => 'We are sorry but there are no longer enough '.$product->title.' rooms available for '.date('d/m/Y',strtotime($night)).'.<br />Please '.l('/book', 'try searching again')));
                            }
                        }
                    }
                }
            }
        }
        break;
    case 'new':

        break;

    case 'update':

        break;

    }
}

Hi all,
if all available rooms are already in cart, the following code prevent the rooms showing up in the search form, based on 7.x-1.0-beta1 code.
hope it will help.

[edit]
it removes the room type from search result, if available quantity in database for the booking dates are already in the cart of person/session responsible for booking.
sorry for bad english.