The token [order-last-comment] is currently passed through check_plain() which is fine as a default. However, it would be great to be able for the admin to allow HTML to be sent in the order comment (i.e. to link to a tracking #). A new token that doesn't escape the comment would solve the problem. I've attached a patch that adds [order-last-comment-raw].

CommentFileSizeAuthor
uc_order_comment_raw.patch1.69 KBjrust

Comments

jrust’s picture

jrust commented

BTW, you could argue that [order-last-comment] shouldn't be escaped since it is admin input and it's not escaped on the view order screen. So, why escape it for the email? But, maybe it doesn't hurt to have a token for each.

cha0s’s picture

cha0s commented
Status: Active » Needs review

I think there should be the option to send it raw, maybe not the default, but an option.

rszrama’s picture

rszrama commented
Category: bug » feature
Issue tags: +ubercamp sprint
rszrama’s picture

rszrama commented
Status: Needs review » Fixed

Committed. Remember to roll patches from the ubercart directory, not the subdirectory of the particular module.

Status: Fixed » Closed (fixed)
Issue tags: -ubercamp sprint

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +ubercamp sprint

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.