Closed (fixed)
Project:
Ubercart
Version:
5.x-1.7
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
10 Feb 2009 at 05:22 UTC
Updated:
27 Feb 2009 at 14:20 UTC
Jump to comment: Most recent file
What's happening is the product report lists out all the SKU combinations available for a product node and breaks down the sales by SKU. However, instead of making a new row for each one, it just uses br tags. This means on narrow displays, reports with long product names have bad alignment. See the attached screenshot.
What needs to happen is each row needs to actually be a row in the table. I want to preserve the way the .odd and .even classes are working, as in they should continue to alternate based on the product, not on the row. So the code should be updated to make all these rows actual rows and to assign the proper class in the row array manually.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | uc_reports-product_rows-1.x-1.patch | 11.68 KB | cha0s |
| #3 | uc_reports-product_rows-2.x-2.patch | 11.16 KB | cha0s |
| #1 | uc_reports-product_rows-1.x.patch | 10.54 KB | cha0s |
| #1 | uc_reports-product_rows-2.x.patch | 11.94 KB | cha0s |
| report-bug.jpg | 40.74 KB | rszrama |
Comments
Comment #1
cha0s commentedHad to duplicate theme_table to make it work right.
Comment #2
Island Usurper commentedI think I should ask for comments in the patch, since it wasn't obvious to me until I looked at the affected page that it doesn't show the model breakdown if there's only one.
The model breakdown is the only chance this page has for displaying the SKU, so I think it should be kept. I also wouldn't have noticed an unrelated bug without it. Besides, it's beyond the scope of this issue, anyway.
Comment #3
cha0s commentedK, here's a new patch..
Comment #4
Island Usurper commentedGreat. Committed to both branches.