What's happening is the product report lists out all the SKU combinations available for a product node and breaks down the sales by SKU. However, instead of making a new row for each one, it just uses br tags. This means on narrow displays, reports with long product names have bad alignment. See the attached screenshot.

What needs to happen is each row needs to actually be a row in the table. I want to preserve the way the .odd and .even classes are working, as in they should continue to alternate based on the product, not on the row. So the code should be updated to make all these rows actual rows and to assign the proper class in the row array manually.

Comments

cha0s’s picture

Assigned: Unassigned » cha0s
Status: Active » Needs review
StatusFileSize
new11.94 KB
new10.54 KB

Had to duplicate theme_table to make it work right.

Island Usurper’s picture

Status: Needs review » Needs work

I think I should ask for comments in the patch, since it wasn't obvious to me until I looked at the affected page that it doesn't show the model breakdown if there's only one.

The model breakdown is the only chance this page has for displaying the SKU, so I think it should be kept. I also wouldn't have noticed an unrelated bug without it. Besides, it's beyond the scope of this issue, anyway.

cha0s’s picture

Status: Needs work » Needs review
StatusFileSize
new11.16 KB
new11.68 KB

K, here's a new patch..

Island Usurper’s picture

Status: Needs review » Fixed

Great. Committed to both branches.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.