While testing #2457823: Implement TFA login requirement when TFA has not been set up I got those notices generated multiple time during the login process. Those appear when a user has only setup TOTP for their account (and no validation).

Warning: Invalid argument supplied for foreach() in tfa_basic_tfa_context_alter() (line 218 of tfa_basic.module). 
Notice: Undefined index: fallback in tfa_basic_tfa_context_alter() (line 218 of tfa_basic.module).
CommentFileSizeAuthor
#1 2481215_1_tfa_basic_notices.patch749 bytesscor
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

scor’s picture

scor CreditAttribution: scor at Acquia commented
Issue summary: View changes
Status: Active » Needs review
FileSize
2481215_1_tfa_basic_notices.patch749 bytes

simple patch.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles at CARD.com commented

I didn't test, but +1 conceptually.

  • coltrane committed 596f203 on 7.x-1.x authored by scor 
    Issue #2481215 by scor: PHP notices when no fallback setup
coltrane’s picture

coltrane
he/him
CreditAttribution: coltrane commented
Status: Needs review » Fixed

Thank you @scor. Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.