Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

CommentFileSizeAuthor
#18 system-stream-wrapper-3289927-d10-compatibility-18.patch3.02 KBtrevorbradley
#17 system-stream-wrapper-3289927-d10-compatibility-17.patch2.6 KBtrevorbradley
#15 3289646-drupal-10-compatibility-13.patch438 bytestrevorbradley
#13 3289646-drupal-10-compatibility-13.patch438 bytestrevorbradley
#12 system-stream-wrapper-issues-3289927-d10-compatibility-12.patch3.08 KBalvarodemendoza
#11 system-stream-wrapper-issues-3289927-d10-compatibility-11.patch3.52 KBloopy1492
#6 interdiff#6.txt678 bytesajeet_kumar
#6 system_stream_wrapper-3289927#6.patch2.61 KBajeet_kumar
#5 system_stream_wrapper-drupal-check-json.txt761 bytesajeet_kumar
#5 interdiff.txt1.71 KBajeet_kumar
#5 system_stream_wrapper-3289927#5.patch2.7 KBajeet_kumar
#4 ssw_1.x-dev.rector-3289927-4.patch1018 byteskunalgautam
#2 system_stream_wrapper.1.x-dev.rector.patch447 bytesproject update bot

Issue fork system_stream_wrapper-3289927

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

project update bot commented
Status: Active » Needs review
StatusFileSize
new system_stream_wrapper.1.x-dev.rector.patch447 bytes

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module this patch makes this module compatible with Drupal 10! 🎉
This patch updates the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #127

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.9
  2. palantirnet/drupal-rector: 0.12.0
project update bot’s picture

project update bot commented
Issue summary: View changes

Updating bot issue summary.See #3313904: Update project bot templates for RTBC status support and human interaction tips

kunalgautam’s picture

kunalgautam commented
Issue summary: View changes
StatusFileSize
new ssw_1.x-dev.rector-3289927-4.patch1018 bytes

Re-roll patch for Drupal version 10.1.x

ajeet_kumar’s picture

ajeet_kumar
Primary language English
commented
Assigned: Unassigned » ajeet_kumar
StatusFileSize
new system_stream_wrapper-3289927#5.patch2.7 KB
new interdiff.txt1.71 KB
new system_stream_wrapper-drupal-check-json.txt761 bytes

I reviewed and verify patch with 8.x.1.x version with Drupal 10 there is non ignorable issues found. Drupal 10 compatibility issues fixed.

ajeet_kumar’s picture

ajeet_kumar
Primary language English
commented
StatusFileSize
new system_stream_wrapper-3289927#6.patch2.61 KB
new interdiff#6.txt678 bytes

I reviewed and verify patch with 8.x.1.x version with Drupal 10 there is non ignorable issues found. Drupal 10 compatibility issues fixed.

abhinavk’s picture

abhinavk commented
Status: Needs review » Reviewed & tested by the community

I tested patch #6 in drupal 10.0.8 and it looks good to me. Module is made d10 compatible with this patch.

Moving this to RTBC.

steffenr’s picture

steffenr
Primary language German
Location Bremen
commented

Thanks for your work on making the module D10 ready.
Can you provide a new 1.x-dev release please, since the issue is marked as being RTBC?

Thanks in advance,
SteffenR

loopy1492 made their first commit to this issue’s fork.

loopy1492 opened merge request !2

loopy1492’s picture

loopy1492 commented
StatusFileSize
new system-stream-wrapper-issues-3289927-d10-compatibility-11.patch3.52 KB

I've created a Merge Request for the maintainers to merge and for us to use in our composer.json file.

alvarodemendoza’s picture

alvarodemendoza commented
StatusFileSize
new system-stream-wrapper-issues-3289927-d10-compatibility-12.patch3.08 KB
trevorbradley’s picture

trevorbradley commented
StatusFileSize
new 3289646-drupal-10-compatibility-13.patch438 bytes

I have no idea why, but patch #12 does not deploy against the dev branch. Here's my revised version:

EDIT: BAD FILE DO NOT USE DO NOT USE (Why can't I delete this?)

trevorbradley’s picture

trevorbradley commented
Status: Reviewed & tested by the community » Needs review
trevorbradley’s picture

trevorbradley commented
StatusFileSize
new 3289646-drupal-10-compatibility-13.patch438 bytes

Darn it, uploaded the wrong file...

EDIT: BAD FILE DO NOT USE DO NOT USE (Why can't I delete this?)

trevorbradley’s picture

trevorbradley commented
trevorbradley’s picture

trevorbradley commented
StatusFileSize
new system-stream-wrapper-3289927-d10-compatibility-17.patch2.6 KB

Sorry folks, my brain is broken on Friday. Let's try this one last time.

EDIT: Nope, that's no good either - I'm not including the new composer.json file. Let me get this right.

trevorbradley’s picture

trevorbradley commented
StatusFileSize
new system-stream-wrapper-3289927-d10-compatibility-18.patch3.02 KB
trevorbradley’s picture

trevorbradley commented

Sorry for all the spam folks.

I'm a bit stumped as to why #12 isn't applying but #18 is. Someone better check this one last time.

I moved this out of "Reviewed and Tested" back to "Needs Review". Something's not quite right with #12.

guedressel’s picture

guedressel commented
Status: Needs review » Reviewed & tested by the community

@TrevorBradley I'm not sure what you tried to accomplish with your patches, but since a main aspect is to introduce the composer.json file into the module, you may use the merge request !2 in your projects composer.json until the maintainers create a new release including the D10 adoptions from that merge request.

You may want to read https://www.drupal.org/docs/develop/git/using-gitlab-to-contribute-to-dr...

Merge request !2 works fine.
Switching to RTBTC

alvarodemendoza’s picture

alvarodemendoza commented

@guedressel Is not recommended to use the MR as a patch because this can be changed by anyone and it's a security risk. If you find an issue you with no patch you should create the patch, basically copying the patch in the MR to a patch file and upload it. This will help to keep the repos safe until the patch is committed.

stborchert’s picture

stborchert
he/him
Primary language German
commented

@AlvaroDeMendoza Simply using a patch file won't work if you try to upgrade your site using composer. Composer reads the module dependencies from the composer.json shipped with the module and would still get the old information from the repository.
Example: running composer why-not drupal/core10.1 with the latest development version of system_stream_wrapper installed will result in drupal/system_stream_wrapper 1.x-dev requires drupal/core (^8 || ^9) even if you apply the patch using composer.
Using the branch (issue fork) of the merge request bypasses the problem, since composer directly uses this branch and gets the correct module dependencies.
If you worry about someone randomly changing the code within the merge request you are able to lock the module in your composer.json on a specific commit (see https://www.drupal.org/docs/develop/git/using-gitlab-to-contribute-to-dr... linked by @guedressel).

RTBC+1 btw

alvarodemendoza’s picture

alvarodemendoza commented

Thank you @stBorchert. That's better than using drupal linient.

drudrup made their first commit to this issue’s fork.

fernly’s picture

fernly commented

@ TrevorBradley the patch struggle is real ;-)

For anyone wondering, patch #12 works against version 1.0.0-alpha3 (that is not latest dev, but the alpha3 version). I, for one, prefer alpha over dev.

RTBC +1

deviantintegral’s picture

deviantintegral commented

Hey folks, thanks for the efforts on this! I gave it a review. I'd like to sync with Dave Reid too, but he's unavailable right now. Regardless, let's aim to get this committed by the end of the week.

I left a few review notes on the MR. Nothing major, this is pretty close to done.

A total aside:

basically copying the patch in the MR to a patch file and upload it. This will help to keep the repos safe until the patch is committed.

Actually, _technically_ patch files are vulnerable to code swaps too. A regular user can't do it, but there's no authenticity or integrity checks beyond what HTTPS provides in transport. At Lullabot, we've standardized on always committing a copy of a patch to the repository and never referencing them with `https://...`: https://architecture.lullabot.com/adr/20220429-composer-patch-files/

deviantintegral’s picture

deviantintegral commented

I've updated from my review notes earlier. I also fixed up tests and got them running on GitLab: https://git.drupalcode.org/project/system_stream_wrapper/-/pipelines/51933. I've left the old test bot in place for now.

My plan is to merge this Monday, and switch over to a semantic module version release at the same time, tag a 1.0, and opt in to security coverage.

deviantintegral’s picture

deviantintegral commented
Title: Automated Drupal 10 compatibility fixes » Drupal 10 compatibility

deviantintegral’s picture

deviantintegral commented
Status: Reviewed & tested by the community » Fixed

Thanks everyone for the initial work on this. The MR is committed, tests are passing, and I tagged a 2.0.0 release to get us into semver.

https://www.drupal.org/project/system_stream_wrapper/releases/2.0.0

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.