Closed (fixed)
Project:
Suggested Terms
Version:
6.x-1.3
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
2 Nov 2007 at 14:41 UTC
Updated:
6 Feb 2013 at 20:11 UTC
Jump to comment: Most recent file
Suggestedterm module should have weight more then taxonomy module weight otherwise thi module does not works at all.
At form alter time modules _alter hooks called in wight then alphabetical order. After install Suggestedterm have weight 0 after install and _alter hook clled before taxonomy module hook. So there are no taxonomy at node form at Suggestedterm form_alter hook call time. Such module weight correction can be done in .install file. You need change weight field in system table record corresponding Suggestedterm module. Good idea will be set this weight to taxonomy weight + 1.
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | 188786-module-weight-notes-10.patch | 1.66 KB | bbinkovitz |
| #8 | README.txt.patch | 660 bytes | j0nathan |
Comments
Comment #1
garryp commentedI changed suggestedterm module weight to 1. This required a db manual edit - not good. There is no .install file for this module.
Can this be fixed the right way, i.e. at install please?
Also, terms I have added via freeform input now show up. However, terms added via the Taxanomy module do not show up. Is there a way that terms added from tax module also show as choices along with those added on the fly?
Comment #2
Crell commentedI have run this module on a couple of sites now without changing the module weight, and it works fine. Are you sure that is the problem?
For the manually-added terms, what is your sort method? Terms that are unused are not going to show up, because they haven't been used.
Comment #3
garryp commented"Are you sure that is the problem?"
;-) I am not so arrogant as to be sure of anything.
However, the module did not work. I made it's weight +1 based on a comment I found here (cannot find the comment now that everything has been moved around). That suggestion went over my head. But I made the change directly within the db, and no other changes. It now works. Was it the problem? Wish I knew!
However, terms added via Tax module do not show up. Terms added on the fly do show up, and are added to Tax Terms as expected.
I could find no tables associated with this module except term, so I have not the slightest idea how it can tell the difference between those added in Tax module and those added on the fly!
It is a really cool module, apparently with limitations.
Comment #4
Crell commentedI've committed an install file to set the weight to taxonomy+1. If that doesn't fix it, please reopen this issue.
For the terms added via the admin issue, please open a new issue. Thanks.
Comment #5
(not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.
Comment #6
j0nathan commentedHi,
The terms were not showing up and the weight of the module suggestedterms was 1. The weight of the core module taxonomy is 0.
I've found the module hs_taxonomy (sites/all/modules/hierarchical_select/modules/hs_taxonomy.module) with a weight of 2, so I decided to increase the weight of the module suggestedterms to 3 and it works, the terms are showing up.
To help choosing a good weight, note that the module i18ntaxonomy (sites/all/modules/i18n/i18ntaxonomy/i18ntaxonomy.module) has a weight of 5. I don't know if suggestedterms should be below or not.
Comment #7
Crell commentedI'm not really inclined to try and account for every taxonomy-modifying module's interactions. There's just too many of them to do sanely. Rather, it's probably something we should document in the INSTALL.txt file. Can you roll a documentation patch to explain the situation and what to do about it?
Comment #8
j0nathan commentedHi,
I've included a short description into README.txt.
Would you verify please.
Comment #9
rsvelko commentedweight = 3 works for me...
FYI:
dr sql-query "UPDATE {system} SET weight = 3 WHERE name = 'suggestedterms'"
Comment #10
bbinkovitz commentedI've combined the last two comments' information and did some editing. Here's the patch:
Comment #11
bbinkovitz commentedComment #12
bbinkovitz commentedSince putting this info in the README is pretty much the only thing that can be done about this short of making this module's weight a huge number (and possible causing problems thereby), I'm committing this and marking it fixed.