Problem/Motivation

In InfoParserDynamic.php line 96:
                                                                                                                                                                                                 
  The 'core_version_requirement' can not be used to specify compatibility for a specific version before 8.7.7 in modules/contrib/styled_google_map/modules/data/styled_google_map_data.info.yml

Steps to reproduce

Install version 2.1 and run drush updb, the error will appear (Drupal 9.4.6)

Proposed resolution

See https://git.drupalcode.org/project/module_builder/-/commit/8b92bda9f7c6b... for a possible fix as used by the module_builder module

Remaining tasks

Implement the fix

User interface changes

N/A

API changes

N/A

Data model changes

N/A

CommentFileSizeAuthor
#7 3312301-6.patch2.39 KBtechnoveltyco
#4 interdiff_2-4.txt211 bytesimmaculatexavier
#4 3312301-4.patch737 bytesimmaculatexavier
#2 3312301-2.patch737 bytesimmaculatexavier

Issue fork styled_google_map-3312301

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Jelle_S created an issue. See original summary.

immaculatexavier’s picture

immaculatexavier commented
Status: Active » Needs review
StatusFileSize
new 3312301-2.patch737 bytes

Attached patch in accordance to the proposed resolution

jelle_s’s picture

jelle_s
Primary language Dutch
Location Antwerp, Belgium
commented 
+++ b/composer.json
@@ -23,5 +23,8 @@
+    "drupal/core": "<8.4"

This should be "<8.6" I believe

immaculatexavier’s picture

immaculatexavier commented
StatusFileSize
new 3312301-4.patch737 bytes
new interdiff_2-4.txt211 bytes

@Jelle_S
Addressed #3. Kindly find the attached patch

technoveltyco made their first commit to this issue’s fork.

technoveltyco opened merge request !1

technoveltyco’s picture

technoveltyco commented
StatusFileSize
new 3312301-6.patch2.39 KB

@jelle_s @immaculatexavier thanks for reporting this issue and creating the patch

The changes at #4 apply correctly, but the issue still remains at the core_version_requirement of the 2 submodules data and demo, which will also require to update their correspondent .info files in order to completely fix the issue.

I re-rolled the patch from #4 and added the missing changed in 3312301-6.patch.

These changes are also pushed to the issue fork 3312301-the-coreversionrequirement-can.

I've tested the one of the projects where we found this issue.

Please review the patch and confirm it works as expected.

Many thanks

a.dmitriiev’s picture

a.dmitriiev commented
Status: Needs review » Fixed
a.dmitriiev’s picture

a.dmitriiev commented

Thank you for finding and fixing the bug so quickly.

I have released the new version 2.2.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.