Hello,
I have noticed that translations for menu items are not currently supported.
I am aware that the work for this is important.
I have developed a solution but of course I would like your opinion.
Thanks
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 2960620-support-for-translations-of-menu-items-2.patch | 19.2 KB | daniel.delaiglesia |
| #2 | 2960620-support-for-translations-of-menu-items.patch | 18.55 KB | daniel.delaiglesia |
Issue fork structure_sync-2960620
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
daniel.delaiglesia commentedMy proposed solution.
Thanks!
Comment #3
fidovdbos commented@daniel.delaiglesia thnx for the patch i wil take a look at it right a way.
Comment #4
daniel.delaiglesia commentedHi again,
I've updated patch. It solve small problem into MenuSyncForm.php file
Thanks.
Regards
Comment #5
steveoriolHello daniel.delaiglesia,
When I use patch # 4, I get a lot of "Warning" like this:
Comment #6
colanNew features go into HEAD, which may turn out to be a 2.x branch if we have one.
Comment #7
fmb commented@steveoriol that's because you need to export your menu links before as the structure of data changes to take languages into account.
Comment #8
fmb commentedRe-rolled patch, updated and fixed some parts of it. Works for me™.
Comment #10
tostinni commentedI had also some problems with the previous patch using the UI (Warning: Illegal string offset 'menu_name') and the safe import, so here is an updated patch that Works for me™ ^^
Thank you for the work on this.
BTW in this patch, previous contributors have added the support for additional fields, see #2980893: New fields added to the menu cannot be exported.
Comment #11
tostinni commentedA small change to support Translatable menu link uri module through the
link_overridefield.This way you can translate the URI and it will be exported to.
Comment #12
elkaro commentedHaving this feature for the 2.0.x version of the module would be a blessing. I have a large menu that needs translating and this would be a tremendous help.
Comment #16
mparker17To make this easier to review, I've created a merge request. The patch didn't apply properly, so I tried to re-create it, but I may have made a mistake in doing so: please ensure that the changes in the merge request fixes the problem and report back here.
Note that this is a patch to an unsupported branch (8.x-1.x). I haven't yet had a chance to determine if this issue is still present in the 2.x branch, nor if this patch would also apply there; @elkaro, do you know if it is still an issue in the 2.x branch?
Comment #17
mparker17Marking as "Maintainer Needs More Info", awaiting a response to the question in #16.
Comment #18
ressaThanks @mparker17, this is still relevant for version 2, and since last 1.x release was January 2019, maybe we should target version 2?
Comment #19
ressaJust a tip: Until Structure Sync gets support for translating menus, Menu migration (Import & Export) (https://www.drupal.org/project/menu_migration) supports this -- both via the GUI, and Drush commands, for export and import:
drush menu_migration:quick-export main