When an invoice is automatically created from a timetracking, the request date and due date are both 01-Jan-70.

Comments

tchurch’s picture

I think this was caused because of #787822: Implement support for Date popup module on Ticket and Invoice Date Fields being in version 1.33.

This should automatically be fixed when the above issue is fixed.

If #794638: Replace 0 with NULL for all date related fields. is also committed (once I've done it) it should clear up the issues with the dates.

I've manually patched my clients website to fix this on 1.33.

I can post the patch here too if anyone else wants to use it. Note - the patch is only for 1.33 as it looks like the -dev version doesn't contain this error.

juliangb’s picture

I tested this by invoicing just a timetracking. Surely this has nothing to do with tickets?

Does your patch simply remove the ticket date code as per -dev?

tchurch’s picture

The code for #787822: Implement support for Date popup module on Ticket and Invoice Date Fields was added for processing of ticket AND invoice dates to allow using date_popup.

The temporary patch I have (for 1.33) would be for invoice dates (as these could be blank).

My client doesn't use tickets and found the problem in invoicing timetracking records.

tchurch’s picture

Version: 6.x-1.x-dev » 6.x-1.33
StatusFileSize
new3.15 KB

I've attached a patch to remove the invoice code for 1.33 if anyone wants to use it.

tchurch’s picture

Version: 6.x-1.33 » 6.x-1.x-dev
Status: Active » Needs work

( I expect this patch to fail on -dev because of #684016: Fix E_NOTICE notifications but it does work.)

tchurch’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, remove_787822.patch, failed testing.

francewhoa’s picture

StatusFileSize
new27.83 KB

I can confirm this issue with Storm 1.33. Mine are dated 1969-12-31

I would be happy to contribute patch testing.

Detail steps to reproduce this issue. Scroll down the handbook under Step 6/6 Add one Invoice section. Hope this helps: http://drupal.org/node/854056

Note to self: Find attached screenshot to clarify issue location.

tchurch’s picture

Version: 6.x-1.x-dev » 6.x-1.33
Status: Needs work » Fixed

Well, the patch failed because the problem does NOT exist on the dev version. It only exists on 1.33.

I suggest anyone having the problem should manually apply the patch or upgrade to the -dev version.

francewhoa’s picture

Thanks tchurch. Are you referring to the patch in comment #4? If not could you post the patch here too? I would like to use it for 1.33.

francewhoa’s picture

StatusFileSize
new218.61 KB

Confirming patch in #4 works with Storm 1.33. Thanks tchurch :)

@all: If you're not able to apply patch find attached the already patched Storm 1.33 module. Not for production/live site.

francewhoa’s picture

Patch in #4 fix issue with dates. But creates an issue with Invoice View. Multiple copies of same invoice are display in Invoice View. Opening a new issue #857154: Multiple copies of same invoice are display in Invoice View

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.