Hello. First of all, sorry for my bad english and if I ask something stupid. I am a newbe. I hope you will understand it.
So, I've just tried out storm (drupal 6.14, storm 6x-1.30). When I wanted to add a created expense to an invoice (existing or new does not matter) the data of the expense was not added correctly. It is not included in the invoice - such as amount, tax etc. When I added to a new invoice, the invoice not contains items at all, and the amounts and taxes are all zero.
Is it a bug or I missed or missunderstood something?
I also did not find on the expense form this "including information such as whether it is billable." (written in the documentation). I did find it on the time tracking form, but not here.
Im am not a programmer and this feature would be quite important for me. Could anyone help me, please?
Thanks Attila
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | stormexpense.module.patch | 2.21 KB | Magnity |
| #1 | stormexpense.module.patch | 2.19 KB | Magnity |
Comments
Comment #1
Magnity commentedHere is an initial stab at a patch to deal with this.
May still need some work.
Comment #2
Magnity commentedThe attached patch has been committed, which I believe now fixes this issue.
Please do test the development version (6.x-1.x-dev) from midnight tonight.
Comment #3
Csete Attila commentedThanks!
Adding the created expense to a new invoice is now ok, apart from it not applies the tax only if I open the invoice and save it again.
Adding the created expense to an existing invoice still not works.
It generates an error message:
user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 1 query: DELETE from storminvoice_items WHERE invoice_vid = in /home/mozartbu/public_html/sites/all/modules/storm/storminvoice/storminvoice.module on line 662.
On the server I got mysql 5.0.87.
Comment #4
Csete Attila commentedOops. Sorry
I haven't noticed your last post.
I'll do it tomorrow and I"ll post the result.
Attila
Comment #5
Magnity commentedSounds promising, because those were the bugs fixed between #1 and #2...!
Comment #6
Csete Attila commentedI've tested the new dev version as you recommended. It works properly for me. Thanks.
I still did not find on the expense form this: "including information such as whether it is billable."
It is not critically important for me but it is written in the documentation, and it would be useful.
I did find it on the time tracking form, but not here.
Attila
Comment #7
Magnity commentedThere isn't currently a bilable/billed flag for expenses. Where in the docs is it written?
Probably a good idea to put it in, but I think that's more of a feature so will come lower in my time priority list i'm afraid.
Comment #8
Magnity commentedBillable/billed flag bit spun off into #695976: Add billable/billed flags to expenses, making this issue fixed.