Since I now have a testing environment for our internal STORM installation, I decided to test out the dev version of STORM.

Upgrading from 1.23 to 6.x-1.x dated July 30st gave me these errors on the update.php page:

* warning: array_merge() [function.array-merge]: Argument #2 is not an array in /Library/WebServer/Documents/example.com/update.php on line 174.
 * warning: Invalid argument supplied for foreach() in /Library/WebServer/Documents/example.com/update.php on line 338.

However, the SQL codes for each update went fine.

The following queries were executed

storminvoice module
Update #6102
Update #6103
Update #6104
Update #6105

stormattribute module
Update #6108
Update #6109

stormexpense module
Update #6101
Update #6102

I remove the actual SQL explanations to make this report shorter to read.

Do you need any other information to make sure there warning do not show up when updating?

Comments

Magnity’s picture

Magnity commented

Thanks for the report - is the error only on the update screen, or do you see it whilst using Storm too?

xmacinfo’s picture

xmacinfo
he/him
Primary language French
Location Canada
commented

Those warnings are only seen on the upgrade screen. :-)

Magnity’s picture

Magnity commented

Is there any chance of trying update.php again with the devel module activated? This can provide a back trace to see where the issue is coming from. I'm not sure if you'd have to roll back to your 1.23 then update or whether the warning will show again if update.php is executed again on the dev version.

There has been a change which introduced the array_merge() function (line 718 of stormtask.module), but the second argument is clearly always an array ($args = array_merge($args, array($project_nid));). I suspect somewhere though the update.php is running through a function without the arguments that it would see in everyday usage...

Magnity’s picture

Magnity commented

I'd like to solve this issue before the release of 6.x-1.24.

(See #540212: Testing of -dev version before 6.x-1.24 release)

Magnity’s picture

Magnity commented
Title: Upgrade errors 6.x-1.23 to 6.x-1.x dated July 30st » Array_merge warnings on upgrade 6.x-1.23 to 6.x-1.x dated July 30st
Priority: Normal » Minor
Status: Active » Postponed (maintainer needs more info)

I've just updated a 1.23 to the latest dev, and cannot see any warnings or anything in logs.

Therefore, i'm going to have to leave this unless there is more information available.

As stated originally, the update goes fine, so it is simply a warning which doesn't affect the operation of the site.

Magnity’s picture

Magnity commented
Status: Postponed (maintainer needs more info) » Fixed

Documented in release notes for 1.24 -> not an ideal solution but will warn users that the site is ok.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.