I intend to combine the modules Storm Invoice and Storm Invoice Item into a single module (Storm Invoice).

Reasoning:
- On initial installation the number of modules (& dependencies) hinders the user experience.
- I believe that most users if using invoices would also use invoice items.
- I believe that most users would give the same permissions for invoice items as invoices.
- There is only one entry on the Storm dashboard - there is an intuitive link

Obviously this single change is not going to make a massive impact on user experience, but I think it will be a step in the right direction without much of a limit on functionality.

Please could people feedback on whether this will cause problems for anyone's installations.

Comments

dbt102’s picture

dbt102 commented

Sounds good to me

Roberto Gerola’s picture

Roberto Gerola commented

Hi.

I originally kept the invoice items module separated to be able to associate
every item with a node and use all the nodes features if necessary : tagging,
extension via cck, views (to create custom reports).

Roberto

Magnity’s picture

Magnity commented

Yes, my plan would be to keep that, merely combining the two so that the one module defines both content types.

I understand that would make the set less intuitive from a developer's point of view, but I think it would be slightly better from a user's point of view because it would remove an option on installation. One of the things I struggled with myself when I first started using Storm was the number of modules there are (So I simply enabled everything ;) )

Do you have any views on that?

Roberto Gerola’s picture

Roberto Gerola commented

I agree with you, but, do the Drupal hooks permit this ?
I mean, two content types defined in one module ?
I never tried this honestly, but it could be possible.

Many thanks for undertaking Storm project.
I hope to be able to provide some help too.

Magnity’s picture

Magnity commented

An update on this: I have started consolidating these modules together.

Permissions for invoice items are now fully based on Storm Invoice.

This is in the -dev release and will be fully completed prior to the next stable release.

Magnity’s picture

Magnity commented
Component: Code » Storm Invoices

Update:

There will be several commits coming in at midnight from other issues, then assuming no bugs from those, I will be committing some changes which eliminate the Storminvoiceitem module.

The code is still a bit messy though, and will need some testing prior to release.

Magnity’s picture

Magnity commented

Storminvoiceitem module now does not exist. Please test as I hope to release a new stable version soon.

Thanks

Magnity’s picture

Magnity commented
Status: Active » Fixed

Tentatively, I am posting this as fixed.

The current status is that the Storminvoiceitem module is no more (all functionality is handled by the Storminvoice module) and there is an upgrade path to ensure database continuity across this change.

There seem to have been a few bugs in the process but these are being covered by other issues.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.