Change storm/organizations page to be made by views

+++ b/stormorganization/stormorganization.info
@@ -2,6 +2,8 @@ name = Storm Organization
+dependencies[] = storm

Repeat of storm dependency.

+++ b/stormorganization/stormorganization.module
@@ -186,24 +177,11 @@ function stormorganization_menu() {
-  $items['admin/config/storm/organization'] = array(
-    'title' => 'Storm organization',
-    'description' => 'Storm organization administration page',
-    'page callback' => 'drupal_get_form',
-    'page arguments' => array('stormorganization_admin_settings'),
-    'access arguments' => array('Storm: access administration pages'),
-    'type' => MENU_LOCAL_TASK,
-  );

Not sure we should be getting rid of this.

+++ b/stormorganization/stormorganization.module
@@ -513,10 +491,12 @@ function stormorganization_load($nodes) {
+    if($record) {    ¶

Trailing whitespace.

+++ b/stormorganization/stormorganization.views_default.inc
@@ -0,0 +1,124 @@
+  $handler->display->display_options['title'] = 'stormorganization_list';

This is what is failing the test - title of the page should be "Organizations"

+++ b/stormorganization/stormorganization.views_default.inc
@@ -0,0 +1,124 @@
+  ¶
+  $views[$view->name] = $view;
+  ¶

Trailing whitespace.

#9: stormorganization-viewslist-1848238-comment9.patch queued for re-testing.

Actually, fewer comments than I thought - let me test before you worry about reposting...

+++ b/stormorganization/stormorganization.info
@@ -2,6 +2,7 @@ name = Storm Organization
 dependencies[] = storm
 package = Storm
+dependencies[] = views
 core = 7.x

Very minor - makes sense if we put the dependency lines together.

+++ b/stormorganization/stormorganization.module
@@ -185,8 +176,7 @@ function stormorganization_menu() {
-  $items['admin/config/storm/organization'] = array(
+  $items['admin/config/storm/organization/'] = array(

As you commented in IRC, shouldn't add a slash here.

+++ b/stormorganization/stormorganization.module
@@ -513,10 +498,12 @@ function stormorganization_load($nodes) {
+    if($record) {    ¶

Whitespace, but less important - I can fix this on commit if vim is giving trouble.

As discussed in IRC, it'd be great if the view was closer to the D6 one:
- Country field rather than description
- Edit / delete links in one column separated by a space

Thanks!

Last thing I think we should do before committing this is ensure the edit / delete links are in the same column - I get the Operations column but with only the edit link in it from the below patch.

Also - quick question:

+++ b/stormorganization/stormorganization.module
@@ -513,10 +498,12 @@ function stormorganization_load($nodes) {
+    $record = array();
     $record = $result->fetchAssoc();
-
-    foreach ($record as $key => $value) {
-      $node->$key = $value;
+    if($record) {
+      foreach ($record as $key => $value) {
+        $node->$key = $value;
+      }

Why this change?

Thanks - will review this again when I'm next coding for Storm.

Amended patch to combine the columns.

Have committed this.