As per title and other issues covering similar topics.

CommentFileSizeAuthor
#7 addbodyfieldtostormticket-1820634-7.patch2.81 KBesoteric1
#6 addbodyfieldtostormticket-1820634-6.patch2.85 KBesoteric1
#2 addbodyfieldtostormticket-1820634-2.patch2.85 KBesoteric1

Comments

esoteric1’s picture

esoteric1 commented
Assigned: Unassigned » esoteric1
esoteric1’s picture

esoteric1 commented
Status: Active » Needs review
StatusFileSize
new addbodyfieldtostormticket-1820634-2.patch2.85 KB

Let me know if there are any problems. I made the same changes that are in the other storm modules for the body field.

juliangb’s picture

juliangb commented
Status: Needs review » Needs work

Thanks for posting!

As far as I can see from reading through, this is great apart from two things:

1) There is trailing whitespace on a few of the empty line in the patch - install dreditor to see this really clearly.

2)

+++ b/stormticket/stormticket.install
@@ -132,3 +139,18 @@ function stormticket_schema() {
+  return 'Added D7 style body field to Storm Task nodes';

Need to change "Task" to "Ticket"

esoteric1’s picture

esoteric1 commented

I guess I'll install that thing. I dont really even know what you mean.

esoteric1’s picture

esoteric1 commented

Okay i see what you are saying. Couldnt get it to work for chrome. but it works with firefox after installing greasemonkey. If you have anything more substantial you'd like done let me know. I browsed through the issue queue but i didnt notice much that i could act on.

esoteric1’s picture

esoteric1 commented
Status: Needs work » Needs review
StatusFileSize
new addbodyfieldtostormticket-1820634-6.patch2.85 KB

Let's see if this one has the whitespaces. I tried to remove them. i think part of the problem is my vim has some indenting thing that is set to 2 spaces for drupal so if i hit enter twice to skip a line, the first one will have those two spaces.

still has whitespaces...

esoteric1’s picture

esoteric1 commented
StatusFileSize
new addbodyfieldtostormticket-1820634-7.patch2.81 KB

another stab...

esoteric1’s picture

esoteric1 commented
Assigned: esoteric1 » Unassigned
juliangb’s picture

juliangb commented

That looks right, will test it.

In terms of anything more substantial, there are a few issues called "Fix xyz list view". Those are pretty substantial, and there is also another node body issue for the team module. If you give me some guidance as to the sort of things you're comfortable with, then I can point you further in the right direction.

juliangb’s picture

juliangb commented
Status: Needs review » Fixed

Tested, committed.

Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.