The "Storm invoice" module allows to generate invoices based on existing projects, tasks, and whatever Storm allows to be billable. Each invoice is represented by a node, and the "Invoice" node view displays the invoice. Also, the invoices can be displayed on a printable HTML page, and in a printable PDF file. However, the nodes don't work as they should.

Most importantly, on the HTML page "Modes for invoice payment" are printed which don't show up in the node display. This is definitely not good as modes for invoice payment are an essential part of the invoice, and the print version(s) should only display data that actually exists on the invoice node.

Also the invoice node outputs data like this:

Amount: 20.00 
Total: 20.00 

Payable in chicken eggs, or maybe in yellow buttons? I can not tell since the node nowhere shows the currency of the invoice. The HTML display at least shows a "Currency" and a "Due total" with currency, and this need to go into the invoice node as well since an invoice without currency is not an invoice ;)

Comments

juliangb’s picture

Title: Invoice nodes incomplete » Add currency to invoice node display
Category: bug » task

Good point re the currency. It should be added.

You might also be interested in #1159022: Reimplement pdf invoices using Print module. I hope once this is complete the pdf, html and standard node view invoices will be much more similar.

juliangb’s picture

Version: 6.x-1.36 » 6.x-2.x-dev
Status: Active » Needs review
StatusFileSize
new842 bytes

Patch for review.

Status: Needs review » Needs work

The last submitted patch, storm--currency-02.patch, failed testing.

kfritsche’s picture

seems fine to me.
Shouldn't it be $organization->currency instead of $myorg->currency?
Otherwise there should be a test, if $myorg is a node.

juliangb’s picture

Status: Needs work » Needs review
StatusFileSize
new861 bytes

Updated patch that only shows this line when a system organisation has been set.

It should be $myorg->... because the core currency on all invoices should be the same in order that they can be summed simply.

This fits with the current display in html and pdf invoices, where no currency is shown apart from for the total in customer currency - then this one is marked as the organisation currency.

juliangb’s picture

StatusFileSize
new866 bytes

Amended patch, removes trailing whitespace.

juliangb’s picture

Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.