Closed (fixed)
Project:
Spam
Version:
6.x-1.x-dev
Component:
Miscellaneous
Priority:
Major
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
10 Dec 2010 at 19:20 UTC
Updated:
25 Dec 2010 at 12:59 UTC
Hi guy,
It looks like this module is not being supported anymore. If I could be given CVS access, then I could at least correct the few problems that make it unusable for many (such as the deletion of comments when attempting to publish them.)
Thank you.
Alexis
Comments
Comment #1
jeremy commentedCan you point toward the patches you've submitted and/or reviewed for this module, first?
It's not actually abandoned, but my efforts are very much on hold lately.
Comment #2
AlexisWilke commentedThere is one patch I contributed for custom filters:
#976958: Custom filter using Plain not quoted!?
The unknown column problem found by Dave:
#977796: Unknown column spam_filter_duplicate_hash
I did not take the time yet to check this one in depth, but if Dave is right, that's a quite big concern:
#984698: spam operations
It seems to me that this one is a no brainer (not submitted by me, but applying it sooner rather than later could be a good idea):
#779010: Use of undefined constant MENU_LOCAL_CALLBACK - assumed 'MENU_LOCAL_CALLBACK'
There is this problem I experienced, now it works, although I don't recall applying that patch...
#670764: Moderated comments marked as spam not in spam queue
There is another one by me:
#813504: Many E_NOTICE when installing all the modules at once
I also proposed a fix here, an invalid UPDATE:
#937384: spam_content_update() is broken - inconsistent hostname derivation
Much less important one here:
#977628: Small spelling error in error message...
I tried the Mark as Spam and it still isn't working. I'm sure I could find the problem, but would want to make sure that the code changes gets in... 8-)
#342915: "Mark the selected comments as spam" not working
Also there are some duplicates. Issues we could close together as things are getting fixed.
Thank you.
Alexis
Comment #3
john franklin commentedThis module has a long list of open issues that make me leery to deploy it. In particular, the PostgreSQL compatibility issues make this module a non-starter for me. If Jeremy doesn't have the personal bandwidth, and Alexis is willing to help out, I'm all for adding him as a co-maintainer. I think that's a win for the module and a win for the community.
Comment #4
gnassar commentedThere are other maintainers, you know. :)
I'm about to push a changeset, myself. Planned that for some time this weekend.
I wouldn't be horribly leery of deploying this -- the usage stats show it to be pretty well adopted. The bugs found have pretty good solutions, and they're (perhaps more importantly) usually touching auxiliary or more specialized use cases. (Case in point: I've been using the unpatched dev version on a production site for a year and change now.)
But of course, that doesn't mean they shouldn't be patched -- they absolutely should, and we've been lax about rolling community patches in. That will hopefully get caught up in most part with this coming dev push.
Comment #5
jeremy commentedAlexis, welcome to the team. I've added you as a maintainer, and we'd greatly appreciate help getting through the huge backlog of outstanding bugs as well as continuing to add features to this module.
Thanks for taking the time to dig up a number of issues where you'd attached patches. I finally made the time to review all the patches you contributed yourself, committing them all. A couple of the issues linked above need further review, but this can be done in the individual issues.
Comment #6
john franklin commentedI have a policy of not deploying dev versions of modules, and I don't really like deploying "release" versions with "beta" or "rc" in the name. If there's a bag of hurt buried in the module and one of my sites finds it, I'm the one getting the 2am phone call and staying up all night fixing it. No me gusta.
I do love Drupal and the community is great, but I've found the hard way some modules are very high quality and some are junk. Over time, I've found a few signs that a module is not up to par and, like a good spam filter, those signs will score it up. Some of those signs are:
* Low usage stats
* A long time since the last release (more than 6 months)
* Many open bugs marked major or critical.
* PostgreSQL bugs (I run several PGSQL sites)
* Bugs that are still open, but long since updated. No bug should be left untouched more than a year. Fix it or close it.
* Releases with "alpha", "beta", "rc" or similar terms in the version number. For the love of the Drop, release with confidence!
Spam only suffers a couple of these issues, and I'm glad Spam has had a surge of activity recently. I have an upcoming project that will need the Spam module and hope that a number of the issues will be taken care of and a release published before then so I can deploy it with confidence.
Just as I try to post a patch when I file a bug, I try to help with solutions when I am critical. With that in mind, is there anything I can do to help out? Do the maintainers have an active PostgreSQL-backed 6.x site? Can I help out with reviewing and testing the PGSQL-related patches?
Comment #7
jeremy commented> Do the maintainers have an active PostgreSQL-backed 6.x site? Can I help out with
> reviewing and testing the PGSQL-related patches?
I personally do not have an active PostgreSQL database, and do not go out of my way to test PostgreSQL unfortunately. Hopefully one of the other maintainers does.
As for helping, absolutely! Test the patches and report back with details results, that's always helpful! The more we see you posting reviews and testing, the more we will learn to rely on your feedback.
Comment #8
AlexisWilke commentedHi John,
I'm using PostgreSQL exclusively. I have a real problem with MySQL... 8-) (although there are a few quirks with pgsql, in comparison with MySQL, they can be laugh at.)
Now that I'm also a maintainer, I will look in a few more of the problems with this module. My goal is to allow my comments to appear automatically (without moderation) so I can let my users comment while I'm sleeping (and the same for my customers.) All of that has not happen yet and I'm afraid that one of the bugs described in the still open list of bugs may hit me in a bad way... So far so good though, I use the module on one of my sites and did not run in any major problems (after I fixed a few problems that were applied to -dev today. Thanks to Jeremy for his review work.)
So if you have patch or problems to report, feel free to do so.
Thank you.
Alexis
Comment #9
gnassar commented