Use of undefined constant MENU_LOCAL_CALLBACK - assumed 'MENU_LOCAL_CALLBACK'

Test with "drush up", no more error message nor notice with Drupal 6.19 + PHP 5.3.2. Patch reroll via spam-6.x-1.x-dev CVS. Should be RTBC?

Thanks, fix committed:
http://drupal.org/cvs?commit=468962

I think this is fine, but just to note: changing it from MENU_LOCAL_CALLBACK to MENU_CALLBACK technically changes functionality. Since MENU_LOCAL_CALLBACK is undefined, this was most likely dropping back to the default MENU_NORMAL_ITEM.

I don't think it should make a difference off the top of my head considering how we use those items, but I thought I'd throw this in here in case we ran into something in the future.

Since the intend was to have MENU_CALLBACK, it makes sense to use that. Also these items are supposed to be hidden so marking them callbacks makes more sense than making them normal items (which the Admin menu, for instance, would then show you!)

Thank you.
Alexis

Right -- that's why I left it as "fixed." But we're guessing at intent, of course, so just wanted to note it so we'd keep an eye out.

As a note -- they don't actually show up as normal items, even when marked as NORMAL_ITEM (like they were before, by accident; I'm sure you noticed they didn't actually show). Since they don't have a parent menu item, they would have no place to appear.

Yes. I checked for a parent and couldn't locate one so thought that the fix was good. 8-)