Closed (fixed)
Project:
Spam
Version:
6.x-1.x-dev
Component:
Miscellaneous
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
21 Nov 2010 at 06:27 UTC
Updated:
9 Jan 2011 at 03:50 UTC
Jump to comment: Most recent file
Comments
Comment #1
Dave Cohen commentedCorrection, spam_filter_duplicate_update_6101() changes variables, not columns. I don't know where the bug lies here, but I dont see how the code could work for anybody.
Comment #2
AlexisWilke commentedActually the update_sql() function does not take %s arguments either... At least last time I checked. 8-)
I suggest the following patch for the 1st error reported (not the misuse of update_sql()).
Thank you.
Alexis Wilke
Comment #3
Dave Cohen commentedLooks resonable to me, I don't know if I have the expertise to "review" it. Have applied it and haven't seen errors.
Comment #4
jeremy commentedThanks, fix committed:
http://drupal.org/cvs?commit=468960
Comment #5
gnassar commentedThis misses the point of update 6101, doesn't it?
The problem was, in the first place, that variables weren't properly namespaced. The fix needs to go in the other direction.
Comment #6
AlexisWilke commented@gnassar,
Ah. That isn't a variable though... It's a field in a namespaced table. Are you sure you want to do that on all the fields?
Thank you.
Alexis
Comment #7
gnassar commentedNo, I think you're correct. I was working under the presumption that the project description was correct and that this has something to do with update_6101. But on second glance, this problem actually has nothing to do with that. It is simply a misnamed field.
Remarking "fixed."