Problem/Motivation

Right now module can't be installed when using PHP 8 as the abraham/twitteroauth:^1 supports only the following versions - "^7.2 || ^7.3 || ^7.4"

Steps to reproduce

composer require drupal/socialfeed when using PHP 8.

Proposed resolution

Update composer.json to require abraham/twitteroauth:^3.1 (unless we need to keep PHP 7.2 support for some reason, in that case only possible version seems to be exactly 2.0.0)
At the first glance, it seems that there aren't any API changes in that dependency that would somehow effect us (constructor and $apiVersion of TwitterOAuth or TwitterOAuth::get).

Issue fork socialfeed-3233065

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

luuph created an issue. See original summary.

luuph opened merge request !7

luuph’s picture

luuph CreditAttribution: luuph as a volunteer commented
Status: Active » Needs review
hemangi gokhale’s picture

hemangi gokhale
she/her/hers
Primary language English
CreditAttribution: hemangi gokhale as a volunteer and commented
Priority: Normal » Major

@luuph, there's a decent amount of code change. Please see compare -> 1.2.0...3.3.0.

Can we have some real reviews here?

almador’s picture

almador CreditAttribution: almador commented

I could confirm the problem:

 Problem 1
    - drupal/socialfeed 1.x-dev is an alias of drupal/socialfeed dev-1.x and thus requires it to be installed too.
    - drupal/socialfeed[dev-1.x, 1.4.0] require abraham/twitteroauth ^1 -> satisfiable by abraham/twitteroauth[1.0.0, 1.0.1, 1.1.0, 1.2.0].
    - abraham/twitteroauth[1.0.0, ..., 1.0.1] require php ^5.6 || ^7.0 || ^7.1 || ^7.2 -> your php version (8.1.5) does not satisfy that requirement.
    - abraham/twitteroauth 1.1.0 requires php ^7.2 || ^7.3 -> your php version (8.1.5) does not satisfy that requirement.
    - abraham/twitteroauth 1.2.0 requires php ^7.2 || ^7.3 || ^7.4 -> your php version (8.1.5) does not satisfy that requirement.
    - Root composer.json requires drupal/socialfeed ^1.4 -> satisfiable by drupal/socialfeed[1.4.0, 1.x-dev (alias of dev-1.x)].

egruel made their first commit to this issue’s fork.

Review and work for me

  • Hemangi Gokhale committed 83a958c on 8.x-1.x 
    Issue #3233065: Upgrade abraham/twitteroauth so that the module could be...
hemangi gokhale’s picture

hemangi gokhale
she/her/hers
Primary language English
CreditAttribution: hemangi gokhale as a volunteer and commented
Status: Needs review » Fixed

I've updated abraham/twitteroauth to ^4 instead of ^3 as PHP 7.3 is in EOL.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.