php drupal-check.phar modules/contrib/social-login/
PHPStan crashed in the previous run probably because of excessive memory consumption.
It consumed around 36 MB of memory.


To avoid this issue, allow to use more memory with the --memory-limit option.
 9/9 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ ------------------------------------------------------- 
  Line   social_login.module                                    
 ------ ------------------------------------------------------- 
  496    Call to deprecated function drupal_set_message().      
  513    Call to deprecated function drupal_set_message().      
  529    Call to deprecated function db_query().                
  532    Call to deprecated function db_delete().               
  533    Call to deprecated function db_delete().               
  754    Call to deprecated function file_prepare_directory().  
  845    Call to deprecated method url() of class Drupal.       
  850    Call to deprecated method url() of class Drupal.       
  855    Call to deprecated method url() of class Drupal.       
  860    Call to deprecated method url() of class Drupal.       
  877    Call to deprecated method url() of class Drupal.       
  888    Call to deprecated method url() of class Drupal.       
  900    Call to deprecated method url() of class Drupal.       
  917    Call to deprecated method url() of class Drupal.       
  928    Call to deprecated method url() of class Drupal.       
  940    Call to deprecated method url() of class Drupal.       
  957    Call to deprecated function db_delete().               
  968    Call to deprecated function db_transaction().          
  974    Call to deprecated function db_merge().                
  977    Call to deprecated function db_delete().               
  981    Call to deprecated function db_select().               
  986    Call to deprecated function db_delete().               
  989    Call to deprecated function db_insert().               
  1024   Call to deprecated function db_query().                
  1032   Call to deprecated function db_query().                
  1109   Call to deprecated function db_query().                
  1125   Call to deprecated method l() of class Drupal.         
  1125   Call to deprecated method l() of class Drupal.         
 ------ ------------------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   src/Controller/SocialLoginController.php           
 ------ --------------------------------------------------- 
  65     Call to deprecated function drupal_set_message().  
  145    Call to deprecated function drupal_set_message().  
  169    Call to deprecated function drupal_set_message().  
  188    Call to deprecated function drupal_set_message().  
  207    Call to deprecated function drupal_set_message().  
  234    Call to deprecated function drupal_set_message().  
  271    Call to deprecated function drupal_set_message().  
  290    Call to deprecated function drupal_set_message().  
  311    Call to deprecated function drupal_set_message().  
  513    Call to deprecated function drupal_set_message().  
  527    Call to deprecated function drupal_set_message().  
  539    Call to deprecated function drupal_set_message().  
  551    Call to deprecated function drupal_set_message().  
  568    Call to deprecated function drupal_set_message().  
  600    Call to deprecated function drupal_set_message().  
  621    Call to deprecated function drupal_set_message().  
  642    Call to deprecated function drupal_set_message().  
  654    Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   src/Form/SocialLoginAdminSettings.php              
 ------ --------------------------------------------------- 
  456    Call to deprecated function db_select().           
  459    Call to deprecated function db_update().           
  463    Call to deprecated function db_insert().           
  466    Call to deprecated function drupal_set_message().  
  516    Call to deprecated function drupal_set_message().  
  523    Call to deprecated function drupal_set_message().  
  607    Call to deprecated function drupal_set_message().  
  610    Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

                                                                                                                        
 [ERROR] Found 54 errors
CommentFileSizeAuthor
#5 social_login-deprecated_code_report-3072857-5-8.x.patch114.15 KBeduardo morales alberti
#4 3072857-4.patch113.45 KBrokzabukovec
#2 deprecated-3072857-2.patch29.1 KBsergiu stici

Comments

Sergiu Stici created an issue. See original summary.

sergiu stici’s picture

sergiu stici commented
Status: Active » Needs review
StatusFileSize
new deprecated-3072857-2.patch29.1 KB

Here is the patch, please review.

ClaudeSchlesser’s picture

ClaudeSchlesser commented

Hello,

thank you very much for the patch, looks great ;)

What I do not like so much is that Drupal::messenger requires Drupal 8.5 and our goal is to have a Drupal 8.x compatible extension. I will have a closer look at your patch, maybe I can change it a bit ;)

rokzabukovec’s picture

rokzabukovec commented
StatusFileSize
new 3072857-4.patch113.45 KB

I created my own patch with deprecation and coding standard fixes. Upgrade status and drupal-check analysis show that now the module is ready for Drupal 9. Please review the patch.
Best regards.

eduardo morales alberti’s picture

eduardo morales alberti
Primary language Spanish
Location Spain, 🇪🇺
commented
Version: 8.x-2.88 » 8.x-2.89
StatusFileSize
new social_login-deprecated_code_report-3072857-5-8.x.patch114.15 KB

Repatch to the last version using the module drupal rector, upgrade status and a clean drupal 9 installation.

muaz7731’s picture

muaz7731
Location Malaysia
commented

try out patch from #5 having problem when patching social_login.info.yml

patching file composer.json
patching file social_login.info.yml
Hunk #1 FAILED at 3.
1 out of 1 hunk FAILED -- saving rejects to file social_login.info.yml.rej
patching file social_login.module
patching file src/Controller/SocialLoginController.php
patching file src/Event/SocialLoginUserCreatedEvent.php
patching file src/Event/SocialLoginUserLinkedEvent.php
patching file src/Event/SocialLoginUserLoginEvent.php
patching file src/Form/SocialLoginAdminSettings.php
patching file src/Form/SocialLoginBlock.php
patching file src/Plugin/Block/SocialLoginBlock.php

edit:
quick fix just add below "core: '8.x'" on social_login.info.yml

core_version_requirement: ^8 || ^9