Updating the current Social Auth LinkedIn Implementer to the 4.0x version. This will help in running the implementer in sync with the latest version of Social API.

Issue fork social_auth_linkedin-3295807

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Simran.67 created an issue. See original summary.

Simran.67 opened merge request !1

Simran.67’s picture

Simran.67 CreditAttribution: Simran.67 commented
Status: Active » Needs review
wells’s picture

wells
he/him/his
Primary language English
Location Seattle, WA
CreditAttribution: wells as a volunteer and at Cascade PBS commented
Version: 8.x-2.x-dev » 4.0.x-dev

@Simran.67 this MR needs to be updated to target the 4.0.x branch. I think you'll have to delete the current MR and open a new one to do that.

wells’s picture

wells
he/him/his
Primary language English
Location Seattle, WA
CreditAttribution: wells as a volunteer and at Cascade PBS commented
Status: Needs review » Needs work

Simran.67 closed merge request !1

Simran.67 opened merge request !2

wells’s picture

wells
he/him/his
Primary language English
Location Seattle, WA
CreditAttribution: wells as a volunteer and at Cascade PBS commented
Status: Needs work » Needs review

@Simran.67 in addition to the CRs added to MR !2, please also update the social_auth_linkedin.links.task.yml to use the correct routes for the new Social Auth 4.0.x implement. Take a look at social_auth_github/-/blob/4.0.x/social_auth_github.links.task.yml for example of how the configuration should be updated.

wells’s picture

wells
he/him/his
Primary language English
Location Seattle, WA
CreditAttribution: wells as a volunteer and at Cascade PBS commented
Status: Needs review » Needs work

@Simran.67 there were some missed CRs from the last round and I have added a couple of new ones. Also note my comment in #8 has an additional CR for the social_auth_linkedin.links.task.yml file. We're almost there (:

Simran.67’s picture

Simran.67 CreditAttribution: Simran.67 commented
Status: Needs work » Needs review
wells’s picture

wells
he/him/his
Primary language English
Location Seattle, WA
CreditAttribution: wells as a volunteer and at Cascade PBS commented
Status: Needs review » Needs work
Simran.67’s picture

Simran.67 CreditAttribution: Simran.67 commented
Status: Needs work » Needs review
wells’s picture

wells
he/him/his
Primary language English
Location Seattle, WA
CreditAttribution: wells as a volunteer and at Cascade PBS commented
Status: Needs review » Needs work

One final CR -- otherwise this looks good!

Simran.67’s picture

Simran.67 CreditAttribution: Simran.67 commented
Status: Needs work » Needs review
wells’s picture

wells
he/him/his
Primary language English
Location Seattle, WA
CreditAttribution: wells as a volunteer and at Cascade PBS commented
Status: Needs review » Needs work

@Simran.67 -- just two more CRs on the \Drupal\social_auth_linkedin\LinkedInAuthManager::getUserInfo method changes. I provided some more details for you this time.

Simran.67’s picture

Simran.67 CreditAttribution: Simran.67 commented
Status: Needs work » Needs review

  • wells committed e34bc3e on 4.0.x authored by Simran.67 
    Issue #3295807 by Simran.67: Update Social Auth LinkedIn for Social Auth...
wells’s picture

wells
he/him/his
Primary language English
Location Seattle, WA
CreditAttribution: wells as a volunteer and at Cascade PBS commented
Status: Needs review » Fixed

Merged! Thanks, @Simran.67!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.