There is documentation for the Social Auth Github module here: https://www.drupal.org/docs/8/modules/social-api/social-api-2x/social-au... , however it is not present in the README of Social Auth Github.

CommentFileSizeAuthor
#10 social_auth_github-update-link-3025058-10.patch4.53 KBneel24
#7 social_auth_github-updated-links-3025058-7.patch1004 bytesneel24
#5 social_auth_github-updated-links-3025058-5.patch997 bytesneel24
#2 social_auth_github-updated-readme-2904374-1.patch463 bytesneel24
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

neel22 created an issue. See original summary.

neel24’s picture

neel24 CreditAttribution: neel24 at Google Code-In commented
FileSize
social_auth_github-updated-readme-2904374-1.patch463 bytes

Created a patch which fixes the issue.

neel24’s picture

neel24 CreditAttribution: neel24 at Google Code-In commented
Status: Active » Needs review
gvso’s picture

gvso
Primary language Spanish
CreditAttribution: gvso at Google Code-In, Google Summer of Code commented
Title: Add documentation link to README for Social Auth GitHub » Update links to documentation
Status: Needs review » Needs work
Parent issue: » #3024073: [META] Update links to documentation

This still doesn't cover all the things we need to update in the README file. Take a look at #3024688: Update links to documentation for an example

neel24’s picture

neel24 CreditAttribution: neel24 at Google Code-In commented
FileSize
social_auth_github-updated-links-3025058-5.patch997 bytes

Ok, have created another patch based on the example provided in #4.

neel24’s picture

neel24 CreditAttribution: neel24 at Google Code-In commented
Status: Needs work » Needs review
neel24’s picture

neel24 CreditAttribution: neel24 at Google Code-In commented
FileSize
social_auth_github-updated-links-3025058-7.patch1004 bytes

Sorry, forgot to add a detail in the previous patch. Below is the correct one, please ignore the one in #5.

neel24’s picture

neel24 CreditAttribution: neel24 at Google Code-In commented
gvso’s picture

gvso
Primary language Spanish
CreditAttribution: gvso at Google Code-In, Google Summer of Code commented
Status: Needs review » Needs work

Please, take a look at the example commit and the changes it introduced. There were changes to the README file (many of them not included in the first patch) *AND* changes to .module file. We need a single patch that addresses all these changes

neel24’s picture

neel24 CreditAttribution: neel24 at Google Code-In commented
FileSize
social_auth_github-update-link-3025058-10.patch4.53 KB

Alright, I've created a patch which addresses changes for both the README and the .module file

neel24’s picture

neel24 CreditAttribution: neel24 at Google Code-In commented
Status: Needs work » Needs review

  • gvso committed c56f9c6 on 8.x-2.x 
    Issue #3025058 by neel22: Update links to documentation
gvso’s picture

gvso
Primary language Spanish
CreditAttribution: gvso at Google Code-In, Google Summer of Code commented
Status: Needs review » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.