Problem

Given a piece of content is made public by a normal user, and later the public visibility is disabled.
When the author (LU) want to make changes to the content, and save the change: it will make the visibility of the content into 'community wide' visible. Now there is no way users can only change the content while keep the visibility public. This applies the same to content managers and site managers when they want to edit a piece of content.

Solution

1. Make sure a CM and SM can ALWAYS change visibility settings of content they can edit, regardless of the permissions that the owner (LU) of the content has.
2. Whenever the owner (LU) wants to edit his/her own content AND the visibility settings are set to public, the owner (LU) cannot change the visibility settings

CommentFileSizeAuthor
only optin is community wide visible.jpg17.79 KBEvelienschut

Comments

Evelienschut created an issue. See original summary.

jochemvn’s picture

jochemvn commented

This was originally by design, however not very well thought of. Suggested solution is the following:

1. Make sure a CM and SM can ALWAYS change visibility settings of content they can edit, regardless of the permissions that the owner (LU) of the content has.
2. Whenever the owner (LU) wants to edit his/her own content AND the visibility settings are set to public, the owner (LU) cannot change the visibility settings

Any thought or suggestions are welcome.

jochemvn’s picture

jochemvn commented
Status: Active » Needs review

Has been fixed and can now be reviewed
https://patch-diff.githubusercontent.com/raw/goalgorilla/open_social/pul...

ronaldtebrake’s picture

ronaldtebrake commented
Status: Needs review » Reviewed & tested by the community

Works well, will be release as part of beta 9!

jochemvn’s picture

jochemvn commented
Issue summary: View changes

  • jochemvn committed 0db3421 on 8.x-1.x 
    #2842079 by jochemvn: Move visibility settings to opensocial settings
  • jochemvn committed 6612454 on 8.x-1.x
    #2842079 by jochemvn: Create permission to override disabled public...
  • ronaldtebrake authored a11183f on 8.x-1.x
    Merge pull request #236 from goalgorilla/feature/2842079

#2842079 -...
ronaldtebrake’s picture

ronaldtebrake commented
Status: Reviewed & tested by the community » Fixed
Evelienschut’s picture

Evelienschut commented
Status: Fixed » Needs work

Unfortuantly Bug is not resolved entirely.
What is working: SM/CM are able to publish normal users contant to public.
What is not working: If the author edits his content (which was made public by a CM) the content is set to 'community' upon save.

jochemvn’s picture

jochemvn commented
Priority: Normal » Critical
ronaldtebrake’s picture

ronaldtebrake commented
Status: Needs work » Needs review

This is up for review, you can find the patch here:

https://patch-diff.githubusercontent.com/raw/goalgorilla/open_social/pul...

ronaldtebrake’s picture

ronaldtebrake commented
Assigned: Unassigned » frankgraave
frankgraave’s picture

frankgraave commented
Status: Needs review » Reviewed & tested by the community

  • ronaldtebrake committed 032d7b8 on 8.x-1.x 
    #2842079 by ronaldtebrake - dont hide the public visibility disable it...
  • ronaldtebrake committed 6265788 on 8.x-1.x
    #2842079 by ronaldtebrake - dont hide the public visibility disable it...
  • frankgraave authored 720c5de on 8.x-1.x
    Merge pull request #350 from goalgorilla/feature/2842079-visibility-...
jochemvn’s picture

jochemvn commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.