I am creating this issue to fix some minor issues on the admin UI:

  • The description of the "Enabled provider" field is a copy of the description of the "Retry sending mail on error." checkbox.
  • The header of table of providers is shorter than its rows - the colspan must be increased. Also, the column should be called "Operations" as other Drupal's tables.
  • Typo on the "SMTP Server Settingssss" fieldset.
  • The submit button of the provider's edition form should be called "Save" instead of "Submit".
  • When editing the provider's machine name, the textfield appears outside the fieldset.
  • smtp_admin_provider_delete_submit() expects a third parameter which is not provided.
  • After a provider is deleted, the user is not redirected back to configuration form.

Comments

dbiscalchin created an issue. See original summary.

dbiscalchin’s picture

StatusFileSize
new2.09 KB

Patch to fix the above mentioned issues.

dbiscalchin’s picture

Status: Active » Needs review
dbiscalchin’s picture

Issue summary: View changes
Status: Needs review » Active

Reopening to fix these issues too:

  • smtp_admin_provider_delete_submit() expects a third parameter which is not provided.
  • After a provider is deleted, the user is not redirected back to configuration form.
dbiscalchin’s picture

StatusFileSize
new2.84 KB

Fixing the last two issues too.

dbiscalchin’s picture

Status: Active » Needs review
chris matthews’s picture

Status: Needs review » Needs work

Great improvements, but the 2 year old patch no longer applies to 7.x-2.x-dev
error: patch failed: smtp.admin.inc:65
error: smtp.admin.inc: patch does not apply

bluegeek9’s picture

Assigned: dbiscalchin » Unassigned
Status: Needs work » Closed (outdated)
//www.flaticon.com/free-icons/thank-you Thank you for your contribution!

Unfortunatly, Drupal 7 is End of Life and no longer supported. We strondly encourage you to upgrade to a supported version of Drupal.

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.