Small thought - It might be a good idea to trim leading & trailing blank space from the SMTP server field on the configuration page. (Perhaps on the other config fields, too?)

I kept getting connection errors and then realized I had an invisible space on the end that got in there from copying & pasting the server address.

CommentFileSizeAuthor
#3 smtp-n1906408-3.patch2.83 KBdamienmckenna

Comments

simon georges’s picture

simon georges commented
Version: 7.x-1.0-beta2 » 7.x-1.x-dev
Category: bug » feature
alpiniste’s picture

alpiniste
Location Highland
commented
Issue summary: View changes

I fully agree with the motion, having just spent ages to figure out what was wrong…

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review
StatusFileSize
new smtp-n1906408-3.patch2.83 KB

Something like this?

chris matthews’s picture

chris matthews commented
Status: Needs review » Needs work
Issue tags: +Needs reroll, +Needs rework

The 3 year old patch in #3 does not apply to the latest 7.x-1x-dev snapshot and may be too old to reroll, but I went ahead and tagged the issue accordingly.

Checking patch smtp.mail.inc...
error: while searching for:
    $from_name = FALSE;
    if (function_exists('i18n_variable_get')) {
      if (i18n_variable_get('smtp_fromname', $message['language'], '') != '') {
        $from_name = i18n_variable_get('smtp_fromname', $message['language'], '');
      }
      else {
        // If value is not defined in settings, use site_name.
        $from_name = i18n_variable_get('site_name', $message['language'], '');
      }
    }

    if (variable_get('smtp_client_hostname', '') != '') {
      $mailer->Hostname = variable_get('smtp_client_hostname', '');
    }

    if (variable_get('smtp_client_helo', '') != '') {
      $mailer->Helo = variable_get('smtp_client_helo', '');
    }

    // If i18n is not enabled, we get the From Name through normal variables
    if (!$from_name) {
      if (variable_get('smtp_fromname', '') != '') {
        $from_name = variable_get('smtp_fromname', '');
      }
      else {
        // If value is not defined in settings, use site_name.
        $from_name = variable_get('site_name', '');
      }
    }

error: patch failed: smtp.mail.inc:82
error: smtp.mail.inc: patch does not apply
bluegeek9’s picture

bluegeek9 commented
Status: Needs work » Closed (outdated)
Issue tags: -
//www.flaticon.com/free-icons/thank-you Thank you for your contribution!

Unfortunatly, Drupal 7 is End of Life and no longer supported. We strondly encourage you to upgrade to a supported version of Drupal.

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.