Remove deprecated code for Drupal 9

Changes so far look good, would need to check the unit test stuff, could be bugs in phpstan or maybe those tests really are broken.

Rather than using the static \Drupal::messenger() call, the messenger service should be injected into SimplesamlphpDrupalAuth.php. It already has a number of other services injected, so this should be an easy fix.

I triggered testing of the patch in #3, and you can see from the output https://www.drupal.org/project/simplesamlphp_auth/issues/3047241 that you introduced one new coding standard violation, which should be fixed. The test failures seem to be branch failures unrelated to this patch.

If you set the issue to needs review the test will be triggered automatically.

This update removes MessengerTrait and injects messenger service and module handler.

Updating the test.

-function simplesamlphp_auth_user_form_includes(&$form) {
+function simplesamlphp_auth_user_form_includes(array &$form) {

This is an API change. It doesn't belong in this issue. I'm not sure why this change was included in this patch, because it has nothing to do with deprecated code.

   /**
-   * Redirect anonymous users from the Drupal login page directly to the external IdP.
+   * Redirect anonymous users from the Drupal login page directly to the
+   * external IdP.

This fixes one coding standards issue - line > 80 characters, but causes a new coding standards issue - function short description should be one line. Again, this is not a deprecated code problem so it should not be addressed here.

My comment in #5 did NOT mean that you should try to fix all the coding standards problems in the existing code - those should be handled in a separate issue. Instead, I simply meant that the patch should not introduce NEW coding standards issues.

What happened to the changes to SimplesamlphpDrupalAuthTest.php? They don't show up in your patch, but DO show up in your interdiff ...

What happened to the url() fixes?

What I was expecting was a patch similar to #8 but using injection instead of MessengerTrait.

The patch above was for #3052166: Coding style fixes. I was uploading a patch for this issue and one that issue, and I must have accidentally uploaded the wrong patch. The filename even references that issue.

That being said, that's some good feedback and I'll take that into account on the other issue.

Adding array type hint to simplesamlphp_auth_user_form_includes() isn't really an api change, because it's a helper function, you can't override it, and when you call it, you don't add a type hint, you'd use it like this:
simplesamlphp_auth_user_form_includes($form);
So the type hint wouldn't change the usage.

This is good feedback:

This fixes one coding standards issue - line > 80 characters, but causes a new coding standards issue - function short description should be one line. Again, this is not a deprecated code problem so it should not be addressed here

I'll fix that on issue 3052166.

The patch above was still wrong (same as 9, from wrong branch). Here's an update.

Fixing the php error.

+++ b/src/Service/SimplesamlphpDrupalAuth.php
@@ -127,7 +149,8 @@ class SimplesamlphpDrupalAuth {
       // We let the user know about this and redirect to the user/login page.
-      drupal_set_message(t("We are sorry. While you have successfully authenticated, you are not yet entitled to access this site. Please ask the site administrator to provision access for you."));
+      $this->messenger
+        ->addMessage(t('We are sorry. While you have successfully authenticated, you are not yet entitled to access this site. Please ask the site administrator to provision access for you.'), 'status');
       $this->simplesamlAuth->logout(base_path());

Lets also switch this to $this->() while touching these lines? Might have committed it, but it needs reroll anyway.

• Rerolling
• Adding MessengerTrait
• Converting calls to t() to $this->t().

Thanks, committed.