"Stop Sending" not working when unpublished

Thinking I've run into the same issue. Stopping doesn't seem to work as expected?

It works for me. This needs a clear "steps to reproduce" for me to be able to work on it please.

@AdamPS I don't know what to tell you for steps. It's pretty straight forward. Stop sending a news letter so you can re-send it and it acts like it doesn't stop because re-sending never works.

The "Send Status" icon never changes from the green checkmark when stopping.

Like nofue mentioned, selecting the news letter, choosing Stop sending and apply to selected items does refresh the page, however it never changes the "Send Status" icon. Thus, turning around and re-selecting the same newsletter and choosing "Send newsletter issue" acts like it works, but no newsletters are actually sent.

For me, simplenews 3.x-dev is completely worthless in my environment. It was upgraded from the 2.x-dev branch which worked just fine.

Environment is PHP 8.0.28

Great thanks I see it now. I was missing step 2 "unpublished" - which I agree was mentioned, however it's much easier to see with "steps to reproduce"😃. Let's make the title more obvious too.

The test was wrong - it checked for the same wrong result that the old code generated.

Even with the patch, I am unable to use the "Stop Sending" functionality.

@AdamPS I'm sure the module works great in your environment, but I'm saying it doesn't work in mine.

For my workflow, I don't create a new newsletter for every issue, I re-use the same newsletter. All of the info in the newsletter is dynamically created through a View on a daily basis based on the content of the site so there's no reason for me to have to create a new newsletter and send it off like a "normal" workflow might dictate.

In the past, I simply stopped sending, then did a Send Newsletter which would trigger the same newsletter to send again. This unfortunately isn't working now.

Like I stated before, v2 would show a clock while sending. Successfully finished would show the checkmark. I think stop sending would remove the icons completely? v3 on the other-hand shows the checkmark for successfully sending all of the newsletters but stop sending does not remove this checkmark making it act like it never stops sending. Attempting a re-send doesn't ever send anything making it feel like stop sending isn't actually working. Visually, it certainly doesn't "look" like it stops sending.

Update:

I'm not a coder, but sometimes I can find a piece to a puzzle.

This was changed in the patch:

@@ -267,7 +267,7 @@ class SpoolStorage implements SpoolStorageInterface {
    * {@inheritdoc}
    */
   public function deleteIssue(ContentEntityInterface $issue) {
-    if ($issue->simplenews_issue->status != SIMPLENEWS_STATUS_SEND_PENDING) {
+    if (!in_array($issue->simplenews_issue->status, [SIMPLENEWS_STATUS_SEND_PENDING, SIMPLENEWS_STATUS_SEND_PUBLISH])) {
       return;
     }

I added the status to the + line:

SIMPLENEWS_STATUS_SEND_READY,

Which makes:

    if (!in_array($issue->simplenews_issue->status, [SIMPLENEWS_STATUS_SEND_READY, SIMPLENEWS_STATUS_SEND_PENDING, SIMPLENEWS_STATUS_SEND_PUBLISH])) {

Whether it's right or not, I don't know, however stopping the send "appears" to work.

I can't get the emails to actually fire off yet which may be another issue altogether, but at least adding the SEND_READY to that line makes the stopping appear to do what it's supposed to.

ECDHE-ECDSA-AES128-GCM-SHA256:128 CV=yes: SMTP error from remote mail server after end of data: 550-5.7.26 Unauthenticated email from xyzdomain.example is not accepted due to\n550-5.7.26 domain's DMARC policy. Please contact the administrator of\n550-5.7.26 xyzdomain.example domain if this was a legitimate mail. Please\n550-5.7.26 visit\n550-5.7.26 https://support.google.com/mail/answer/2451690 to learn about the\n550 5.7.26 DMARC initiative. n197-20020a25d6ce000000b00b673b42fbecsi13274724ybg.705 - gsmtp

From what I can gather, Drupal isn't setting the correct "from" address and due to DMARC my server is blocking it.

So yes, the email not sending is on my end. However, checking past attempts with SimpleNews to stop and start the message, it did not actually attempt to send the message until after I added the SIMPLENEWS_STATUS_SEND_READY bits.

Hope this is confirmable and not a random freak coincidence.

Update: Figured out the mail issue for anyone curious... In mail system I had SimpleNews set to use Mime Mail. For whatever reason, mimemail doesn't appear to respect the "From:" setting. I changed the mail system setting for the added SimpleNews module to use SwiftMailer instead and it went through.

In the past, I simply stopped sending, then did a Send Newsletter which would trigger the same newsletter to send again. This unfortunately isn't working now.

This is not something that's intended to work - reusing newsletters is not currently supported and once the newsletter has finished sending, then the stop sending button should no longer be present. There is a feature request for it #3056037: Allow resending of newsletters to specific recipients. Or maybe this module could help you but I haven't tested it: https://www.drupal.org/project/simplenews_resend.

This issue is for a specific problem with the steps in #7. If have problems with a different set of steps then please use a different issue.

I'm confused though... This worked fine on v2 but it's being stripped from v3?

So all that is needed to fix #3056037: Allow resending of newsletters to specific recipients is to add SIMPLENEWS_STATUS_SEND_READY in the area mentioned above?

I'm not sure why the separate module is needed when this is already present in simplenews it's just not enabled?

After making the fix suggested above, it works exactly like v2 and I imagine it does exactly the same thing as the resend module.

As a worst case, wouldn't it make sense to put a checkbox setting in the simplenews settings for "Allow resending of Issues" and show/hide the stop send based on that setting? It would be one less module to have to keep track of and I would imagine a lot less actual code overhead.

But what do I know. I'm just the guy trying to use it.

The code was changed in #3052727: Create clear consolidated functions to send/cancel newsletters. I don't really agree it "worked fine" in v2. The purpose of the "Stop sending" button is to stop sending any more emails. Most commonly it would be used before any were sent; it could also be used to abort part way, but then it's not really possible to continue sending as there is no record of who to resend to. Once the newsletter has been sent, it's no longer possible to stop sending, hence the button is should longer be shown. You were using "Stop sending" to reset the newsletter so you could send it again. It is random chance that it worked in that way - it was not logical nor was it the intention.

For #3056037: Allow resending of newsletters to specific recipients, the button should be named "Reset". It should likely reset the statistics. There is a very real danger of sending the same newsletter to the same people, which would tend to be called spam. So maybe it should only work if you reset the newsletter content at the same time (which I guess, you would be happy to do). At minimum there should be a clear warning of the dangers.

It seems to me that creating a new newsletter is not so hard. It has the advantage that you get a clear history of when you sent out newsletters and how many people it was sent to.

@AdamPS

The code was changed in #3052727: Create clear consolidated functions to send/cancel newsletters. I don't really agree it "worked fine" in v2. The purpose of the "Stop sending" button is to stop sending any more emails. Most commonly it would be used before any were sent; it could also be used to abort part way, but then it's not really possible to continue sending as there is no record of who to resend to. Once the newsletter has been sent, it's no longer possible to stop sending, hence the button is should longer be shown. You were using "Stop sending" to reset the newsletter so you could send it again. It is random chance that it worked in that way - it was not logical nor was it the intention.

This does make more sense. For now I'll just use the work-around until it gets stripped completely, then take a look at the resend module you suggested.

I guess make a note that there is "some" demand for the need to resend an existing issue so building it into simplenews might be warranted.

I'll drop off the convo since there shouldn't be anything else on my end to discuss ;-)

@nofue If you can confirm the patch solves your problem then I will commit the fix
@philsward 😃 Could also be worth a look at https://www.drupal.org/project/simplenews_resend

Great thanks for the confirmation. New release coming soon.