Closed (fixed)
Project:
Simplenews
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
8 Oct 2011 at 07:36 UTC
Updated:
15 Dec 2011 at 13:30 UTC
(Like all of the patches which I'm currently posting, this is based on #1164578: Port and extend tests so that one needs to be commited first as this one mit not apply cleanly otherwise)
The attached patch removes a number of functions (some commented out) which are obviously not used (anymore).
- A theme function that is not used anymore
- An access callback function which is not used (maybe that is supposed to be used later, if so, I can update the patch)
- Commented out hook_node_view_alter() and hook_field_extra_fields() functions
- simplenews_get_categories, which is a weird duplicate of simplenews_category_list()
| Comment | File | Size | Author |
|---|---|---|---|
| remove.patch | 4.75 KB | berdir |
Comments
Comment #1
simon georges commentedPatch applies cleanly, does not seem to break anything. Can I have someone else to test it, to be sure I didn't miss anything ?
Anyway, thanks Berdir, it's nice to clean the code!
Comment #2
berdirAnd... this is in as well.
If anything shows up because of this, it's easy to revert..