Comments

nit3ch created an issue. See original summary.

antongp’s picture

D8 version is definitely in our plans.

nit3ch’s picture

Started working on this will update soon.

mdespeuilles’s picture

For information I have created a drupal 8 port of this module on github

https://github.com/mdespeuilles/easymeta

  • antongp committed 1fa83bf on 8.x-1.x
    Issue #2556693 by nit3ch, mdespeuilles: Drupal 8 port. Initial commit.
    
antongp’s picture

Assigned: nit3ch » antongp
Priority: Normal » Major
Status: Active » Needs work
kala4ek’s picture

Could you please create 8.x-1.x dev release, so we can suggest patches?

kala4ek’s picture

Current D8 version does not work at all, right after installation I've got the following:

The website encountered an unexpected error. Please try again later.

Drupal\Core\Entity\Query\QueryException: 'path' not found in Drupal\Core\Entity\Query\Sql\Tables->ensureEntityTable() (line 316 of core/lib/Drupal/Core/Entity/Query/Sql/Tables.php).
Drupal\Core\Entity\Query\Sql\Tables->addField('path', 'INNER', NULL) (Line: 44)
Drupal\Core\Entity\Query\Sql\Condition->compile(Object) (Line: 155)
Drupal\Core\Entity\Query\Sql\Query->compile() (Line: 74)
Drupal\Core\Entity\Query\Sql\Query->execute() (Line: 93)
simplemeta_meta_load_by_path(Array, 'en') (Line: 122)
simplemeta_get_page_meta() (Line: 48)
simplemeta_page_bottom(Array) (Line: 340)
kala4ek’s picture

Assigned: antongp » kala4ek
kala4ek’s picture

Assigned: kala4ek » Unassigned
Status: Needs work » Needs review
StatusFileSize
new8.09 KB

There is some path for the current 8.x-1.x branch.
At least it works :)

kala4ek’s picture

StatusFileSize
new13.5 KB

And finally, another one patch that makes FO widget works too.
Works perfectly for me.

antongp’s picture

Version: 7.x-1.2 » 8.x-2.x-dev
Assigned: Unassigned » antongp

Hello @kala4ek.

Many thanks for your effort. I created 8.x-2.x dev release (not shown on the project page yet) - branch was accidentally named 8.x-1.x, initial D8 version is supposed to be parallel with 7.x-2.x. I'll have a chance to review your patch tomorrow. Actually, from a quick try patch doesn't apply... Does it cleanly apply for you?

kala4ek’s picture

StatusFileSize
new25.06 KB

Yep, found the reason of broken patch.
Should be ok now, for 8.x-2.x branch.

antongp’s picture

Status: Needs review » Needs work

@kala4ek
Could you please provide more details on error you mentioned in #8? Actually I cannot reproduce the problem... What exact Drupal core version was used? Database (but I really doubt it's related)? I believe renaming of the path property to url helped you for some reason, but I'm not sure why. Or there was some other reason for renaming? Also, what was the reason of moving embedding of meta tags from hook_page_bottom() implementation to hook_page_attachments()?

Thanks!

kala4ek’s picture

Status: Needs work » Active

I believe renaming of the path property to url helped you for some reason, but I'm not sure why.

There is conflict with the Pathauto module, which moved the path field to a custom storage. See pathauto_entity_base_field_info() and pathauto_entity_base_field_info_alter().

Also, what was the reason of moving embedding of meta tags from hook_page_bottom() implementation to hook_page_attachments()?

Seems, that default metatags from Metatag module owerride the Simplemeta data.
Also, hook attachments looks more appropriate.

kala4ek’s picture

Status: Active » Needs review
kala4ek’s picture

Any news regarding 8.x version release?

antongp’s picture

Hello @kala4ek. Will have a chance to review on the weekend. Thanks!

mikhailkrainiuk’s picture

Status: Needs review » Reviewed & tested by the community

The patch from #13 comment works nice for me.
Website with Drupal 8.6.7.

benellefimostfa’s picture

Here is a d8 alternative https://www.drupal.org/project/easymeta

nkoporec’s picture

adci_contributor’s picture

adci_contributor’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.