Hello project maintainers,
This is an automated issue to help make this module compatible with Drupal 12.
Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD12" tag from the issue to stop the bot from posting updates.
The changes will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.
You have a few options for how to use this issue:
If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD12" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.
As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.
Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.
If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD12" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD12" tag.
If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.
If the issue is reopened, then new automated changes will be posted.
If you are using another issue(s) to work on Drupal 12 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.
Using the patches
Using the merge request
Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!
If there are problems with one of the changes posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | simple_oauth.6.1.x-dev.rector.patch | 68.47 KB | project update bot |
| #5 | interdiff-last-bot.7151849.txt | 606 bytes | project update bot |
| #4 | simple_oauth.6.1.x-dev.rector.patch | 64.29 KB | project update bot |
| #4 | interdiff-last-bot.7141041.txt | 22.52 KB | project update bot |
| #2 | simple_oauth.6.1.x-dev.rector.patch | 37.81 KB | project update bot |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
project update bot commentedThis is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 12 Compatibility
According to the Upgrade Status module these changes make this module compatible with Drupal 12! 🎉
Therefore these changes update the
info.ymlfile for Drupal 12 compatibility.Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 12 compatibility fixes as they become available in Drupal Rector.
Debug information
These packages were used to generate the fixes:
Comment #4
project update bot commentedThis is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 12 Compatibility
According to the Upgrade Status module these changes make this module compatible with Drupal 12! 🎉
Therefore these changes update the
info.ymlfile for Drupal 12 compatibility.Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 12 compatibility fixes as they become available in Drupal Rector.
Debug information
These packages were used to generate the fixes:
Comment #5
project update bot commentedThis is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 12 Compatibility
According to the Upgrade Status module these changes make this module compatible with Drupal 12! 🎉
Therefore these changes update the
info.ymlfile for Drupal 12 compatibility.Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 12 compatibility fixes as they become available in Drupal Rector.
Debug information
These packages were used to generate the fixes:
Comment #7
brian@graith commentedI picked this up because the pipeline is red. The info files already declare
^12, but on Drupal 12.0.0-alpha1 with PHP 8.5.10 every functional and kernel
test that touches OAuth dies with the same error, 55 of them:
Drupal\simple_oauth\Plugin\ScopeProviderManager only supports
annotation-based discovery, which is no longer supported as of Drupal 12.0.
Provide an Attribute class and an Annotation class for BC.
Oauth2GrantManager has the same problem; it just is not reached first.
ScopeGranularityManager has already been converted, so I followed the pattern
that is already in the module rather than inventing one. Added
Drupal\simple_oauth\Attribute\ScopeProvider and
Drupal\simple_oauth\Attribute\Oauth2Grant next to the existing
ScopeGranularity attribute, passed each to its manager as the attribute class
with the existing annotation class kept as the annotation argument for BC, and
put the attributes on the four bundled plugins alongside their annotations.
Results
Drupal 12.0.0-alpha1, PHP 8.5.10: 89 tests, 1 failure. That failure is
ScopeGranularityFormTest::testGranularityForm and it is only failing because
this machine has no WebDriver.
For comparison, the unmodified branch on Drupal 11.4.7 with PHP 8.4.25 gives
exactly the same shape: 89 tests, and the same single JavaScript failure. So
the Drupal 12 result now matches the Drupal 11 baseline rather than being a
count I am asking you to take on trust.
With the change applied on Drupal 11.4.7: still 89 tests, still that one
JavaScript failure, and all three grant plugins still discovered, so nothing
regresses for current users.
phpcs (Drupal, DrupalPractice) reports the same 1 error and 7 warnings across
src/ before and after, and the two new attribute classes are clean.
The blocker that is not in this module
simple_oauth cannot actually be installed on Drupal 12 yet, whatever we do
here, because drupal/consumers still declares ^10.3 || ^11 and its
ConsumerListBuilder::getOperations() carries the pre-Drupal-12 signature:
Declaration of Drupal\consumers\ConsumerListBuilder::getOperations(EntityInterface $entity)
must be compatible with EntityListBuilder::getOperations(EntityInterface $entity, ?CacheableMetadata $cacheability = NULL)
which is a fatal error on cache rebuild. I patched consumers locally to be able
to test this at all; that patch is not part of this MR. It looks like
consumers #3592591 is already tracking exactly that method, with
#3596612 as its bot issue, so this one is effectively waiting on those.
This work was done with AI assistance. Every error string and test count above
came from running the suite on the two sites described.
Comment #10
rajab natshahMR !238 is ready for review.
Comment #11
vidit.anjaria commented