I haven't exactly quantified when it occurs, but some views all across our installation broke when this module was enabled. It appears to be any view that has an exposed Term selector (even though I've not configured it to use shs in Views Filters).
To get it over the hump, I did not change the logic in this module but simply rearranged the order in which things were checked added an isset() before proceeding. Whether this _fixes_ anything with Views Exposed Filter shs I don't believe it will -- but it does allow me to continue using shs on field widgets and not break the rest of the site :)
One fatal PHP error and one PHP notice:
Error: Call to a member function load() on null in Drupal\shs\Plugin\views\filter\ShsTaxonomyIndexTid->valueForm() (line 31 of /var/www/html/web/modules/contrib/shs/src/Plugin/views/filter/ShsTaxonomyIndexTid.php) #0 /var/www/html/web/core/modules/views/src/Plugin/views/filter/FilterPluginBase.php(922): Drupal\shs\Plugin\views\filter\ShsTaxonomyIndexTid->valueForm(Array, Object(Drupal\Core\Form\FormState)) #1 /var/www/html/web/core/modules/views/src/Form/ViewsExposedForm.php(115): Drupal\views\Plugin\views\filter\FilterPluginBase->buildExposedForm(Array, Object(Drupal\Core\Form\FormState)) #2 [internal function]: Drupal\views\Form\ViewsExposedForm->buildForm(Array, Object(Drupal\Core\Form\FormState)) #3 /var/www/html/web/core/lib/Drupal/Core/Form/FormBuilder.php(520): call_user_func_array(Array, Array) #4 /var/www/html/web/core/lib/Drupal/Core/Form/FormBuilder.php(277): Drupal\Core\Form\FormBuilder->retrieveForm('views_exposed_f...', Object(Drupal\Core\Form\FormState)) #5 /var/www/html/web/core/modules/views/src/Plugin/views/exposed_form/ExposedFormPluginBase.php(135): Drupal\Core\Form\FormBuilder->buildForm('\\Drupal\\views\\F...', Object(Drupal\Core\Form\FormState)) #6 /var/www/html/web/core/modules/views/src/ViewExecutable.php(1238): Drupal\views\Plugin\views\exposed_form\ExposedFormPluginBase->renderExposedForm() #7 /var/www/html/web/core/modules/views/src/Plugin/views/display/PathPluginBase.php(390): Drupal\views\ViewExecutable->build() #8
Notice: Undefined property: Drupal\shs\Plugin\views\filter\ShsTaxonomyIndexTid::$vocabularyStorage in Drupal\shs\Plugin\views\filter\ShsTaxonomyIndexTid->valueForm() (line 31 of /var/www/html/web/modules/contrib/shs/src/Plugin/views/filter/ShsTaxonomyIndexTid.php) #0 /var/www/html/web/core/includes/bootstrap.inc(596): _drupal_error_handler_real(8, 'Undefined prope...', '/var/www/html/w...', 31, Array) #1 /var/www/html/web/modules/contrib/shs/src/Plugin/views/filter/ShsTaxonomyIndexTid.php(31): _drupal_error_handler(8, 'Undefined prope...', '/var/www/html/w...', 31, Array) #2 /var/www/html/web/core/modules/views/src/Plugin/views/filter/FilterPluginBase.php(922): Drupal\shs\Plugin\views\filter\ShsTaxonomyIndexTid->valueForm(Array, Object(Drupal\Core\Form\FormState)) #3 /var/www/html/web/core/modules/views/src/Form/ViewsExposedForm.php(115): Drupal\views\Plugin\views\filter\FilterPluginBase->buildExposedForm(Array, Object(Drupal\Core\Form\FormState)) #4 [internal function]:
Patch to follow..
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | shs-views-filter-fatal-error-3131920-2.patch | 4.34 KB | texas-bronius |
Comments
Comment #2
texas-bronius commented