XMLRPC multiple requests

Please explain what you were doing/trying to achive?

The services / xmlrpc server changes very little with how core's xmlrpc functions. All it really does is pass a keyed array, as you would with normal hook_xmlrpc, to core xmlrpc. That said, its likely that is is a core issue rather than a Services issue.

This is obviously very important, however, you and your team likely have way more experience with this than myself. If you find/found its a problem with Services, do let me know and I'll be happy to work with yout to get a patch in.

Thanks,
Scott

Strange ok, someone should have a look at this.

Services XMLRPC is actually served through Drupal's XMLRPC. The xmlrpc_server.module actually implements hook_xmlrpc and exposes the service methods through the hook to Drupal XMLRPC, so it should in theory be combining all services with methods implemented by hook_xmlrpc. It seems not to be the case, but just FYI.

Can you provide some example calls that you are making? I have a couple of ideas where things might be going wrong.

subscribing, I would love to see a working system.multicall too.

Sample call:

require_once './includes/bootstrap.inc';
drupal_bootstrap(DRUPAL_BOOTSTRAP_FULL);
include_once './includes/xmlrpc.inc';
include_once './includes/xmlrpcs.inc';

$url = 'http://example.org/services/xmlrpc';
$calls = array(
  array('user.login', 'name', 'password'),
  array('system.listMethods'),
  array('user.logout'),
  array('system.methodHelp', 'system.listMethods'),
);
$return = xmlrpc($url, $calls);

Attached is a patch that apparently makes it working and possibly gives some hints on what is going wrong.

That patch doesn't work for me. It looks like it starts to loop through all of the methods in the multicall, but then just returns the results from the first one?

My guess is that instead of returning on the call we need to do the following:

  if ($method_name == 'system.multicall') {
    $responses = array();
    $params = $xmlrpc_server->message->params;
    foreach($params[0] as $key => $method) {
      if ($i == $key) {
        $i++;
        if (!in_array($method['methodName'], $core_methods)) {
          $responses[] = services_method_call($method['methodName'], $method['params']);
        }
      }
    }
    return $responses;
  }

Note I haven't tested the concept because I don't have time to set up the required test environment to prove my theory. Patch attached. The nice thing though is that this can be happily be applied to all versions of service without issue.

I don't get why you need the $call_index, or why you need to exclude the four system functions. Can you elaborate on that? It seems like we should be able to just roll through the methods and return the merged array.

I like this functionality but I don't see it compelling enough to hold up releasing the 2.x branch over unless someone wants to drive it home and test it.

That is what the above patch does. Marking this postponed, but if someone gets a good patch in before a release is rolled I'll be happy to check it out.

Bumping to head

This is really a task not a bug

Closing as won't fix as no feed back was given and xmlrpc is now pretty much dead in services