I am querying my Drupal site to find a particular node by its title, by calling eg. node.index(0, '*', {'title': 'Hello, world'}). However, the code (services_resource_build_index_query) interprets this query to mean that I am looking for either a node titled "Hello" or a node titled " world". There is no way to perform the search I need using the services API.
I suggest that instead of assuming $parameter_value is a comma-delimited string, allow it to either be a string or an array of strings.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | serivces-params-escape-d7-1395548-8.patch | 1.21 KB | cotto |
| #5 | serivces-params-escape-1395548-5.patch | 1.45 KB | cotto |
| #4 | services-parameters-escape-1395548-4.patch | 2.31 KB | glennpratt |
| #1 | services-index-parameter-change.diff | 743 bytes | SpindleyQ |
Comments
Comment #1
SpindleyQ commentedSee attached patch for a simple fix.
Comment #2
marcingy commentedthe real answer is that the values should be an array so postponing for 7.x.4 but good idea but we need to do this correctly.
Comment #3
marcingy commentedThis looks like more a general issue we need something that works and its as nice as it could be.
Comment #4
glennpratt commentedHere's my rough patch, just curious what you think about the approach to use CSV style strings, and re-implementing a PHP function as needed.
This would allow:
The code was based from PHP.net comments.
Comment #5
cotto commentedHere's a version of the patch (which is for 6.x-3.x, btw) that removes the whitespace changes and puts all the conditional logic into a wrapper function. I'm not certain what the docs for the wrapper should look like, but that's my best guess. Something like this patch will also be required for 7.x-3.x since it only requires PHP 5.2.5 or higher.
Comment #6
cotto commentedComment #7
kylebrowning commentedlooks good, can we get a 7.x version?
Comment #8
cotto commentedHere you go. I did some very basic testing and it seems to work correctly.
Comment #9
kylebrowning commented