The module doesn't work true for seoigg.de website. I mean when i add this service to my website, it doesn't show title and URL of links true. It shows them like : http://www.seoigg.de/node/add/storylink?edit[url]=%3Cencoded-url%3E&edit... For every page and it doesn't work true. I found the reason too but i can't solve it as i am not a programmer. The problem relates to it:
The Service links module doesn't work true for websites that have [ ...] in their submission URL. For example the source code of link in Service links module for seoigg.de in like this and you can see it in the script too in file "general_services.module" .
http://www.seoigg.de/node/add/storylink?edit[url]=%3Cencoded-url%3E&edit...
As you see, it has [url] and [title] and service links module has problem with it. I ask anyone to fix this huge problem. The module should work fine with links that has [ ...] in their links too but it doesn't work true yet. Please solve it

CommentFileSizeAuthor
#9 service_links-1825036.patch435 bytesTheCrow

Comments

shamio’s picture

shamio commented

Why no one can answer this question? Its a problem in the core of this module and should be solved. Anyone have an idea to solve it?

shamio’s picture

shamio commented
Priority: Minor » Major
swati.karande’s picture

swati.karande commented

Hi,

Every service has a domain and a path which walk until a page once queried, read the various params attached to the link, evaluate their values and add the Drupal's content to its server.
May be seoigg service are not provided correct placeholders in the code.

If you replace the following line in "german_services.module" file then link will encoded properly.

http://www.seoigg.de/node/add/storylink?edit[url]=%3Cencoded-url%3E&edit...
To
http://www.seoigg.de/node/add/storylink?url=%3Cencoded-url%3E&title=%3Ce...

links that has[...] in their links is works for yahoo service. So I think its working but not for every services.

shamio’s picture

shamio commented

Thanks for your reply. But:
1) The provided link for seoigg doesn't work true.
2) As i said, i found the problem and the only problem of this module is with links that have [...] in their link. The link for Yahoo is like below in the source code of module and it doesn't has any [ ...] in the code
'link' => 'http://bookmarks.yahoo.com/myresults/bookmarklet?u=<encoded-url>&t=<encoded-title>',
As i said before, the only problem of this module is with links that have [...] in their link. Can anyone fixes this problem?

fstopr’s picture

fstopr commented
Title: Critical Problem » seoigg.de service not working OR Not all services support elipses [...] in the link
Priority: Major » Normal

I'm not sure this really is a bug, but its certainly not a critical one.

I think one possible work around would be to re-work your urls/pathauto settings so that [...] are not in the urls.

based on the comments from #3, it also sounds like this could just be a update to the service link for seoigg.de pattern.

shamio’s picture

shamio commented

I am sure the best solution is fixing the module that support all websites which have [....] in their links. Even if anyone can fix seoigg, it will be fixed for all the sames URLs from another services too. Someone please fix this issue that enables module to work with [.....] links too.

simon georges’s picture

simon georges commented
Version: 7.x-2.1 » 7.x-2.x-dev

I don't think this has been fixed in the -dev version.

simon georges’s picture

simon georges commented

And cross-referencing #1861982: Problem with dots in a custom service link (or: add the russian service link "odnoklassniki").

TheCrow’s picture

TheCrow commented
Status: Active » Needs review
StatusFileSize
new service_links-1825036.patch435 bytes

The problem is in the PHP function parse_str()

swati.karande’s picture

swati.karande commented

Its working for me!

TheCrow’s picture

TheCrow commented
Status: Needs review » Fixed

Comitted!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.