Problem/Motivation

In SectionLibraryRender.php you do:

$last_item_section = array_pop($sections[$key]);

This will pop the lost item of the array in my case:
['layout-builder__section' => [allSections]

Propose to preserve array key

Patch attached.

Todo

Review & double test/check

CommentFileSizeAuthor
#3 3275451-3-11.diff1.1 KBkriboogh

Issue fork section_library-3275451

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Mschudders created an issue. See original summary.

Mschudders opened merge request !11

kriboogh’s picture

kriboogh commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 3275451-3-11.diff1.1 KB

Tested, applies and works (been using it in production for over a year now).
MR diff added for use in composer.

kevinquillen’s picture

kevinquillen commented

Seems related to #3416266: Switch from using array_pop/array_push for section manipulation to preserve key integrity and ensure module integration compatibility

kevinquillen’s picture

kevinquillen commented
Related issues: +#3416266: Switch from using array_pop/array_push for section manipulation to preserve key integrity and ensure module integration compatibility
rajab natshah’s picture

rajab natshah
he/him
commented
Status: Reviewed & tested by the community » Closed (duplicate)

jastraat closed merge request !11