PHP 8.5 deprecation messages...

Deprecated function: Using null as an array offset is deprecated, use an empty string instead in Drupal\search_api\Entity\Index->getPropertyDefinitions() (line 1018 of modules\contrib\search_api\src\Entity\Index.php).

Deprecated function: Using null as an array offset is deprecated, use an empty string instead in Drupal\search_api\Entity\Index->getPropertyDefinitions() (line 1032 of modules\contrib\search_api\src\Entity\Index.php).

Deprecated function: Using null as an array offset is deprecated, use an empty string instead in Drupal\search_api\Entity\Index->getPropertyDefinitions() (line 1035 of modules\contrib\search_api\src\Entity\Index.php).

Deprecated function: Non-canonical cast (double) is deprecated, use the (float) cast instead in include() (line 576 of vendor\composer\ClassLoader.php).
include() (Line: 576)
{closure:Composer\Autoload\ClassLoader::initializeIncludeClosure():575}() (Line: 427)
Composer\Autoload\ClassLoader->loadClass()
ReflectionClass->__construct() (Line: 139)
Drupal\Component\Plugin\Discovery\AttributeClassDiscovery->parseClass() (Line: 100)
Drupal\Core\Plugin\Discovery\AttributeDiscoveryWithAnnotations->parseClass() (Line: 84)
Drupal\Component\Plugin\Discovery\AttributeClassDiscovery->getDefinitions() (Line: 69)
Drupal\Core\Plugin\Discovery\AttributeDiscoveryWithAnnotations->getDefinitions() (Line: 86)
Drupal\Component\Plugin\Discovery\DerivativeDiscoveryDecorator->getDefinitions() (Line: 337)
Drupal\Core\Plugin\DefaultPluginManager->findDefinitions() (Line: 213)
Drupal\Core\Plugin\DefaultPluginManager->getDefinitions() (Line: 84)
Drupal\search_api\Utility\PluginHelper->createIndexPlugins() (Line: 131)
Drupal\search_api\Utility\PluginHelper->createProcessorPlugins() (Line: 706)
Drupal\search_api\Entity\Index->getProcessors() (Line: 722)
Drupal\search_api\Entity\Index->getProcessorsByStage() (Line: 1028)
Drupal\search_api\Entity\Index->getPropertyDefinitions() (Line: 475)
Drupal\search_api\Item\Field->getDataDefinition() (Line: 307)
Drupal\search_api\Hook\SearchApiViewsHooks->getHandlers() (Line: 99)
Drupal\search_api\Hook\SearchApiViewsHooks->viewsData() (Line: 29)
search_api_views_data() (Line: 228)

System (LOCAL DEV Laragon)

Drupal 11.3.3
PHP v8.5.1
PHP Memory limit: 512M
PHP Caching module: OpCache
CommentFileSizeAuthor
#23 php-8.5-code-fix-3576216.patch7.22 KBsivaji_ganesh_jojodae
#22 php-8.5-code-fix-3576216.patch5.1 KBsivaji_ganesh_jojodae
#21 php-8.5-code-fix-3576216.patch3.69 KBsivaji_ganesh_jojodae
#20 3576216_20.patch2.79 KBsivaji_ganesh_jojodae
#8 php-8.5-code-fix-3576216.patch1.07 KBgulshan verma

Issue fork search_api-3576216

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

sirclickalot created an issue. See original summary.

amritsingh09’s picture

amritsingh09 commented
Assigned: Unassigned » amritsingh09

I will work on a patch for this PHP 8.5 deprecation issue.

hydra made their first commit to this issue’s fork.

hydra opened merge request !315

hydra’s picture

hydra commented

I also ran into this and started working on this.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Version: 8.x-1.40 » 8.x-1.x-dev
Status: Active » Needs work

Tests are failing.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Issue tags: +PHP 8.5
gulshan verma’s picture

gulshan verma commented
StatusFileSize
new php-8.5-code-fix-3576216.patch1.07 KB

Use this patch for this issue.

mably made their first commit to this issue’s fork.

paranojik made their first commit to this issue’s fork.

steinmb’s picture

steinmb commented
Issue summary: View changes

Tests are green again. Are we still missing something or is it ready for review?

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Needs work » Needs review
clayfreeman’s picture

clayfreeman
he/him
Primary language English
commented
Status: Needs review » Needs work

Should also include a fix for the deprecation notices from #3576230: Non-canonical cast (double) is deprecated.

clayfreeman’s picture

clayfreeman
he/him
Primary language English
commented
Title: PHP 8.5.1 code deprecation » PHP 8.5 code deprecation
Issue summary: View changes
clayfreeman’s picture

clayfreeman
he/him
Primary language English
commented
Status: Needs work » Needs review

Scratch that... apparently was already solved in #3558624: PHP 8.5 compatibility.

steinmb’s picture

steinmb commented
Status: Needs review » Reviewed & tested by the community

Looking good to me, LGTM.

sivaji_ganesh_jojodae’s picture

sivaji_ganesh_jojodae commented
Status: Reviewed & tested by the community » Needs work

The patch couldn't be applied needing rebase.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Needs work » Needs review

Rebased.

sivaji_ganesh_jojodae’s picture

sivaji_ganesh_jojodae commented

Thank you. I am seeing the following issue as well,

Deprecated function: Using null as an array offset is deprecated, use an empty string instead in                                       
                                         Drupal\search_api\Plugin\views\field\SearchApiStandard->addRetrievedProperty() (line 366 of                                            
  453   15/May 16:11   php    Debug      Deprecated function: Using null as an array offset is deprecated, use an empty string instead in                                       
                                         Drupal\search_api\Plugin\views\field\SearchApiStandard->expandRequiredProperties() (line 53                                            
  452   15/May 16:11   php    Debug      Deprecated function: Using null as an array offset is deprecated, use an empty string instead in                                       
                                         Drupal\search_api\Plugin\views\field\SearchApiStandard->expandRequiredProperties() (line 52                                            
  451   15/May 16:11   php    Debug      Deprecated function: Using null as an array offset is deprecated, use an empty string instead in                                       
                                         Drupal\search_api\Plugin\views\field\SearchApiStandard->expandRequiredProperties() (line 52
sivaji_ganesh_jojodae’s picture

sivaji_ganesh_jojodae commented
StatusFileSize
new 3576216_20.patch2.79 KB
sivaji_ganesh_jojodae’s picture

sivaji_ganesh_jojodae commented
StatusFileSize
new php-8.5-code-fix-3576216.patch3.69 KB
sivaji_ganesh_jojodae’s picture

sivaji_ganesh_jojodae commented
StatusFileSize
new php-8.5-code-fix-3576216.patch5.1 KB
sivaji_ganesh_jojodae’s picture

sivaji_ganesh_jojodae commented
StatusFileSize
new php-8.5-code-fix-3576216.patch7.22 KB
sirclickalot’s picture

sirclickalot
Primary language English
Location Somerset
commented

Patch from #23 seems to have reduced the number deprecation warnings but I am still seeing others...


Deprecated: Drupal\search_api_glossary\Plugin\search_api\processor\Glossary::getPropertyDefinitions(): Implicitly marking parameter $datasource as nullable is deprecated, the explicit nullable type must be used instead in C:\laragon\www\bit-by-bit.org\public_html\modules\contrib\search_api_glossary\src\Plugin\search_api\processor\Glossary.php on line 46

Deprecated: Drupal\search_api_sort_priority\Plugin\search_api\processor\ContentBundle::getPropertyDefinitions(): Implicitly marking parameter $datasource as nullable is deprecated, the explicit nullable type must be used instead in C:\laragon\www\bit-by-bit.org\public_html\modules\contrib\search_api_sort_priority\src\Plugin\search_api\processor\ContentBundle.php on line 52

Deprecated: Drupal\search_api_sort_priority\Plugin\search_api\processor\FileMime::getPropertyDefinitions(): Implicitly marking parameter $datasource as nullable is deprecated, the explicit nullable type must be used instead in C:\laragon\www\bit-by-bit.org\public_html\modules\contrib\search_api_sort_priority\src\Plugin\search_api\processor\FileMime.php on line 53

Deprecated: Drupal\search_api_sort_priority\Plugin\search_api\processor\MediaBundle::getPropertyDefinitions(): Implicitly marking parameter $datasource as nullable is deprecated, the explicit nullable type must be used instead in C:\laragon\www\bit-by-bit.org\public_html\modules\contrib\search_api_sort_priority\src\Plugin\search_api\processor\MediaBundle.php on line 52

Deprecated: Drupal\search_api_sort_priority\Plugin\search_api\processor\ParagraphBundle::getPropertyDefinitions(): Implicitly marking parameter $datasource as nullable is deprecated, the explicit nullable type must be used instead in C:\laragon\www\bit-by-bit.org\public_html\modules\contrib\search_api_sort_priority\src\Plugin\search_api\processor\ParagraphBundle.php on line 52

Deprecated: Drupal\search_api_sort_priority\Plugin\search_api\processor\Role::getPropertyDefinitions(): Implicitly marking parameter $datasource as nullable is deprecated, the explicit nullable type must be used instead in C:\laragon\www\bit-by-bit.org\public_html\modules\contrib\search_api_sort_priority\src\Plugin\search_api\processor\Role.php on line 58

Deprecated: Drupal\search_api_sort_priority\Plugin\search_api\processor\Statistics::getPropertyDefinitions(): Implicitly marking parameter $datasource as nullable is deprecated, the explicit nullable type must be used instead in C:\laragon\www\bit-by-bit.org\public_html\modules\contrib\search_api_sort_priority\src\Plugin\search_api\processor\Statistics.php on line 55
sirclickalot’s picture

sirclickalot
Primary language English
Location Somerset
commented

Patch from #23 seems to have reduced the number deprecation warnings but I am still seeing others...


Deprecated: Drupal\search_api_glossary\Plugin\search_api\processor\Glossary::getPropertyDefinitions(): Implicitly marking parameter $datasource as nullable is deprecated, the explicit nullable type must be used instead in C:\laragon\www\bit-by-bit.org\public_html\modules\contrib\search_api_glossary\src\Plugin\search_api\processor\Glossary.php on line 46

Deprecated: Drupal\search_api_sort_priority\Plugin\search_api\processor\ContentBundle::getPropertyDefinitions(): Implicitly marking parameter $datasource as nullable is deprecated, the explicit nullable type must be used instead in C:\laragon\www\bit-by-bit.org\public_html\modules\contrib\search_api_sort_priority\src\Plugin\search_api\processor\ContentBundle.php on line 52

Deprecated: Drupal\search_api_sort_priority\Plugin\search_api\processor\FileMime::getPropertyDefinitions(): Implicitly marking parameter $datasource as nullable is deprecated, the explicit nullable type must be used instead in C:\laragon\www\bit-by-bit.org\public_html\modules\contrib\search_api_sort_priority\src\Plugin\search_api\processor\FileMime.php on line 53

Deprecated: Drupal\search_api_sort_priority\Plugin\search_api\processor\MediaBundle::getPropertyDefinitions(): Implicitly marking parameter $datasource as nullable is deprecated, the explicit nullable type must be used instead in C:\laragon\www\bit-by-bit.org\public_html\modules\contrib\search_api_sort_priority\src\Plugin\search_api\processor\MediaBundle.php on line 52

Deprecated: Drupal\search_api_sort_priority\Plugin\search_api\processor\ParagraphBundle::getPropertyDefinitions(): Implicitly marking parameter $datasource as nullable is deprecated, the explicit nullable type must be used instead in C:\laragon\www\bit-by-bit.org\public_html\modules\contrib\search_api_sort_priority\src\Plugin\search_api\processor\ParagraphBundle.php on line 52

Deprecated: Drupal\search_api_sort_priority\Plugin\search_api\processor\Role::getPropertyDefinitions(): Implicitly marking parameter $datasource as nullable is deprecated, the explicit nullable type must be used instead in C:\laragon\www\bit-by-bit.org\public_html\modules\contrib\search_api_sort_priority\src\Plugin\search_api\processor\Role.php on line 58

Deprecated: Drupal\search_api_sort_priority\Plugin\search_api\processor\Statistics::getPropertyDefinitions(): Implicitly marking parameter $datasource as nullable is deprecated, the explicit nullable type must be used instead in C:\laragon\www\bit-by-bit.org\public_html\modules\contrib\search_api_sort_priority\src\Plugin\search_api\processor\Statistics.php on line 55
sirclickalot’s picture

sirclickalot
Primary language English
Location Somerset
commented

Patch from #23 seems to have reduced the number deprecation warnings but I am still seeing others...


Deprecated: Drupal\search_api_glossary\Plugin\search_api\processor\Glossary::getPropertyDefinitions(): Implicitly marking parameter $datasource as nullable is deprecated, the explicit nullable type must be used instead in C:\laragon\www\bit-by-bit.org\public_html\modules\contrib\search_api_glossary\src\Plugin\search_api\processor\Glossary.php on line 46

Deprecated: Drupal\search_api_sort_priority\Plugin\search_api\processor\ContentBundle::getPropertyDefinitions(): Implicitly marking parameter $datasource as nullable is deprecated, the explicit nullable type must be used instead in C:\laragon\www\bit-by-bit.org\public_html\modules\contrib\search_api_sort_priority\src\Plugin\search_api\processor\ContentBundle.php on line 52

Deprecated: Drupal\search_api_sort_priority\Plugin\search_api\processor\FileMime::getPropertyDefinitions(): Implicitly marking parameter $datasource as nullable is deprecated, the explicit nullable type must be used instead in C:\laragon\www\bit-by-bit.org\public_html\modules\contrib\search_api_sort_priority\src\Plugin\search_api\processor\FileMime.php on line 53

Deprecated: Drupal\search_api_sort_priority\Plugin\search_api\processor\MediaBundle::getPropertyDefinitions(): Implicitly marking parameter $datasource as nullable is deprecated, the explicit nullable type must be used instead in C:\laragon\www\bit-by-bit.org\public_html\modules\contrib\search_api_sort_priority\src\Plugin\search_api\processor\MediaBundle.php on line 52

Deprecated: Drupal\search_api_sort_priority\Plugin\search_api\processor\ParagraphBundle::getPropertyDefinitions(): Implicitly marking parameter $datasource as nullable is deprecated, the explicit nullable type must be used instead in C:\laragon\www\bit-by-bit.org\public_html\modules\contrib\search_api_sort_priority\src\Plugin\search_api\processor\ParagraphBundle.php on line 52

Deprecated: Drupal\search_api_sort_priority\Plugin\search_api\processor\Role::getPropertyDefinitions(): Implicitly marking parameter $datasource as nullable is deprecated, the explicit nullable type must be used instead in C:\laragon\www\bit-by-bit.org\public_html\modules\contrib\search_api_sort_priority\src\Plugin\search_api\processor\Role.php on line 58

Deprecated: Drupal\search_api_sort_priority\Plugin\search_api\processor\Statistics::getPropertyDefinitions(): Implicitly marking parameter $datasource as nullable is deprecated, the explicit nullable type must be used instead in C:\laragon\www\bit-by-bit.org\public_html\modules\contrib\search_api_sort_priority\src\Plugin\search_api\processor\Statistics.php on line 55