I gave drupal-check a try and while (quite literally) 99% of warnings were useless, it did find some sub-optimal coding.

CommentFileSizeAuthor
#2 3049801-2--code_cleanup.patch3.64 KBdrunken monkey

Comments

drunken monkey created an issue. See original summary.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Active » Needs review
StatusFileSize
new 3049801-2--code_cleanup.patch3.64 KB
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

These changes look very good, I like being really explit in if statements and this makes that happen.

  • drunken monkey committed 0123d17 on 8.x-1.x 
    Issue #3049801 by drunken monkey, borisson_: Cleaned up some minor code...
drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Reviewed & tested by the community » Fixed

Awesome, thanks for reviewing!
Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.