The getIndexPath method was moved to the WebTestBase. The LanguageIntegrationTeststill defines that method as well and can be removed.

In the setUp method there is also the following code that is outdated, the getTestIndex(); method already sets $this->indexId.

    $index = $this->getTestIndex();
    $this->indexId = $index->id();

This can be changed to $this->getTestIndex();

CommentFileSizeAuthor
#8 interdiff.txt565 bytesshabirahmad
#8 2646642-removed-duplicated-property-8.patch1.44 KBshabirahmad
#4 2646642-removed-unused-code-4.patch1.09 KBshabirahmad

Comments

borisson_ created an issue. See original summary.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Issue summary: View changes

updated IS.

shabirahmad’s picture

shabirahmad commented
Assigned: Unassigned » shabirahmad
shabirahmad’s picture

shabirahmad commented
Assigned: shabirahmad » Unassigned
Status: Active » Needs review
StatusFileSize
new 2646642-removed-unused-code-4.patch1.09 KB

Here's the patch

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

Awesome, thanks.

shabirahmad’s picture

shabirahmad commented

@Borison, Please have a look at the related issue (2646742) as well. We don't need the protected $indexId in the child class since it is already available here.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Reviewed & tested by the community » Needs work

The patch added in #2646742: Remove duplicate indexId property from LanguageIntegrationTest can be integrated in this issue; we don't need a separate issue.

shabirahmad’s picture

shabirahmad commented
Status: Needs work » Needs review
StatusFileSize
new 2646642-removed-duplicated-property-8.patch1.44 KB
new interdiff.txt565 bytes

Okay, here we go!

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

Looks great.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Reviewed & tested by the community » Fixed 
+++ b/src/Tests/LanguageIntegrationTest.php
@@ -47,7 +40,6 @@ class LanguageIntegrationTest extends WebTestBase {
     $index = $this->getTestIndex();
-    $this->indexId = $index->id();

As hinted by borisson_ in the issue summary, it's actually not even necessary to save the return value of $this->getTestIndex().
Fixed that and committed. Thanks a lot for your contribution!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.