Apparently a small oversight in #2574969: Add a Views-like UI for adding fields: in theory, IndexInterface::addField() should now be the single method for changing field settings, but it seems I forgot to remove the $notify parameter from FieldInterface::setType(). Easy to fix, it doesn't seem to be used anyways.

CommentFileSizeAuthor
#3 2641826-2--field_setType_remove_notify.patch1.24 KBdrunken monkey

Comments

drunken monkey created an issue. See original summary.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Issue tags: +Novice

This is a perfect novice issue.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Active » Needs review
StatusFileSize
new 2641826-2--field_setType_remove_notify.patch1.24 KB

Too late.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

  • drunken monkey committed 0672d8b on 8.x-1.x 
    Issue #2641826 by drunken monkey: Removed the $notify parameter from...
drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Reviewed & tested by the community » Fixed

Thanks for reviewing. Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.