We need to catch search block form submissions to make Search Log module work properly with the search block.
While it's generally fine to redirect to the search page right away using GET method, it does not trigger form submit method and callbacks, and thus such searches remain uncaught.
Use POST method for search block form and redirect to the search page in the submit method.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 3439302-4.patch | 3.03 KB | pradhumanjain2311 |
| #2 | drupal-search-block-post-method-3439302-2.patch | 2.43 KB | alex.bukach |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes, plain diff MR !8427
Comments
Comment #2
alex.bukach commentedComment #3
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue.
While you are making the above changes, we recommend that you convert this patch to a merge request. Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)
Comment #4
pradhumanjain2311 commentedFix PHP CBF
Comment #7
quietone commentedChanges are made on on 11.x (our main development branch) first, and are then back ported as needed according to our policies.
Comment #9
quietone commentedThe Search Module was approved for removal in #3476883: [Policy, no patch] Move Search module to contrib .
This is Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.
The deprecation work is in #3565780: [meta] Tasks to deprecate the Search module and the removal work in #3565783: [meta] Tasks to remove the Search module.
Search will be moved to a contributed project before Drupal 12.0.0 is released.
Comment #10
quietone commentedThe Search Module has moved from core to contrib,