Rather than assigning things like .items img and .items div, can you instead make it more specific to the particular module? Maybe at least tag the container with "scrollable_content" as a class and select within that? To me, .items * is pretty generic and could cause adverse side-effects elsewhere in a website.

Comments

good_man’s picture

good_man commented

Yeah I see your point, it's really a common class name so I suggest to put the prefix scrollable-content-*** before each class, what do you think?

texas-bronius’s picture

texas-bronius commented

I wouldn't prefix the classes, either-- simply add the additional class name. I haven't played with the module enough to know, but at least in the Views exposed mode, you are already outputting the ID of scroller. So your module's default css should say things like:

#scroller .items img {
  ..

rather than just

.items img {
  ..

And in general, what I mean by adding additional class names.. Rather than renaming things something like class="scrollable-content-something" just make it class="scrollable-content something" so the css to select it would be:

.scrollable-content.something

Plus, this sort of enhancement would not break existing deployments ;)

Thanks for hearing my two cents!

good_man’s picture

good_man commented
Assigned: Unassigned » good_man
Status: Active » Needs work

Nice explanation, okay gonna work on it for the next release, any more suggestions is highly welcomed.

good_man’s picture

good_man commented

Please check out the new 2.x release, it has better CSS and templates.

good_man’s picture

good_man commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.