Add missing core_version_requirement key to info files [#3108883]

Problem/Motivation

As part of making this module ready for Drupal 9, we should add a missing core_version_requirement key to the module info file.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comment	File	Size	Author
#10	3108883-10-5-interdiff.txt	1.19 KB	mbovan
#10	3108883-10.patch	11.76 KB	mbovan
#10	8.x-1.x: PHP 7 & MySQL 5.5, D8.8.6 run-tests.sh fatal error
#6	3108883-5-2-interdiff.txt	617 bytes	mbovan
#5	3108883-5.patch	12.95 KB	mbovan
#5	8.x-1.x: PHP 7 & MySQL 5.5, D8.8.1 57 pass
#2	3108883-2.patch	12.11 KB	mbovan
#2	8.x-1.x: PHP 7 & MySQL 5.5, D8.8.1 PHPLint Failed

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

25 January 2020 at 15:38

mbovan created an issue. See original summary.

Comment #2

mbovan CreditAttribution: mbovan at MD Systems GmbH commented 25 January 2020 at 15:55

Status:

Active

» Needs review

File	Size
3108883-2.patch	12.11 KB
8.x-1.x: PHP 7 & MySQL 5.5, D8.8.1 PHPLint Failed

This patch adds a necessary core_version_requirement key.

Comment #3

nathandentzau

Rhode Island

CreditAttribution: nathandentzau as a volunteer commented 25 January 2020 at 15:58

@mbovan your patch contains changes that are not related to the core_version_requirement key change. Could you provide some context as your reason for the change and if that should be moved to a different issue?

Comment #4

mbovan CreditAttribution: mbovan at MD Systems GmbH commented 25 January 2020 at 16:22

+++ b/tests/src/Functional/SchemaMetatagTagsTestBase.php
@@ -45,6 +46,11 @@ abstract class SchemaMetatagTagsTestBase extends BrowserTestBase {
+  /**
+   * {@inheritDoc}
+   */
+  protected $defaultTheme = 'stark';

This is needed to make tests passing.

+++ b/tests/src/Functional/SchemaMetatagTagsTestBase.php
@@ -107,7 +113,7 @@ abstract class SchemaMetatagTagsTestBase extends BrowserTestBase {
-      list($config_path, $rendered_path, $save_message) = $item;
+      [$config_path, $rendered_path, $save_message] = $item;

This was an IDE change. Might not be related.

+++ b/tests/src/Functional/SchemaMetatagTagsTestBase.php
@@ -202,7 +208,7 @@ abstract class SchemaMetatagTagsTestBase extends BrowserTestBase {
-      $json = json_decode($elements[0]->getHtml(), TRUE);
+      $json = Json::decode($elements[0]->getHtml());

It seems like json_decode() could be deperecated in the future.

Comment #5

mbovan CreditAttribution: mbovan at MD Systems GmbH commented 25 January 2020 at 16:24

File	Size
3108883-5.patch	12.95 KB
8.x-1.x: PHP 7 & MySQL 5.5, D8.8.1 57 pass

Reverted #4.2.

Comment #6

mbovan CreditAttribution: mbovan at MD Systems GmbH commented 25 January 2020 at 16:24

File	Size
3108883-5-2-interdiff.txt	617 bytes

The interdiff.

Comment #7

nathandentzau

Rhode Island

CreditAttribution: nathandentzau as a volunteer commented 25 January 2020 at 16:52

Hey @mbovan thank you for the context. Sounds good about fixing the test! I just reviewed this locally and works great. RTBC+++

Comment #8

nathandentzau

Rhode Island

CreditAttribution: nathandentzau as a volunteer commented 25 January 2020 at 16:52

Status:

Needs review

» Reviewed & tested by the community

Comment #9

Berdir

German

Switzerland

CreditAttribution: Berdir at MD Systems GmbH commented 25 January 2020 at 19:31

+++ b/src/Plugin/metatag/Tag/SchemaSpeakableTrait.php
@@ -55,16 +55,17 @@ trait SchemaSpeakableTrait {
       '#default_value' => !empty($value['xpath']) ? $value['xpath'] : '',
-      '#description' => $this->t('ex: @example',
-        ['@example' => "'/html/head/title'", "'/html/head/meta[@name=\'description\']/@content']'"),
+      '#description' => $this->t('Separate xpaths by comma, as in: @example',
+        ['@example' => '/html/head/title, /html/head/meta[@name=\'description\']/@content']
+      ),
     ];
 
     $form['cssSelector'] = [
       '#type' => 'textfield',
       '#title' => $this->t('cssSelector'),
       '#default_value' => !empty($value['cssSelector']) ? $value['cssSelector'] : '',
-      '#description' => $this->t('ex: @example',
-        ['@example' => "'#title'", "'#summary'"]
+      '#description' => $this->t('Separate selectors by comma, as in @example',
+        ['@example' => '#title, #summary']
       ),
     ];

Would be better to leave this out of this patch to avoid conflicts with the other issue.