Closed (fixed)
Project:
Scheduler content moderation integration
Version:
2.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
18 Nov 2022 at 09:44 UTC
Updated:
23 Dec 2022 at 15:49 UTC
Jump to comment: Most recent

Comments
Comment #3
smustgrave commentedSo the MR is pointing at the 1.x branch. The plan is make 2.x be the D10 branch which we hope to have a beta release soon. thank you
Comment #4
ankitv18 commentedHi @smustgrave,
We need to remove "drupal/core": "^8.7.7 || ^9", from composer.json file for 2.x release and so that it is fully compatible for D10 release.
Comment #5
ankitv18 commentedComment #6
ankitv18 commentedComment #11
chr.fritschMR is ready for review
Comment #12
jonathan1055 commentedThanks for the fixes @chr.fritsch
I thought that the D10 preparation had all been done in #3289476-14: Automated Drupal 10 compatibility fixes but I can see that we committed #3208882: Update SCMI to support scheduler 2.x entity plugins for media, etc which was not completely D10 ready, but which had missed the automatic fixes bot patch. So some of these changes in MR33 do need to be committed.
However I'm not sure we want to stop supporting D8 on the first SCMI 2.0 release. We should be able to keep D8 support for a while. Scheduler 2.0 will still support D8 so to help those sites who have not updated to D9 yet we should not cut them out of using SCMI 2.0
Comment #13
chr.fritschD8 is dead for a year now. Time to drop it
Comment #14
chr.fritschI brought back the D8 compatibility and ran the tests locally, because on d.o. it's not possible anymore to run D8 tests...
Comment #15
jonathan1055 commentedThanks chr.fritsch. Yes you are right that D8 tests can't be run on drupal.org, so to examine other possibilities I have opened #3324954: Drop Core 8.x compatibility on 2.x branch. Add testing at MAX_PHP so we can continue the discussion there.
Comment #16
jonathan1055 commentedTests passed at D9 and D10. Last commit puts back the explicit version dependencies in .info and composer.json. I think this is better than not to specify any version. Is that right?
Comment #17
chr.fritschIf drupal/core is not specified in the composer.json, d.o.'s composer facade will add the version requirements from the info.yml to packagist. So I think it makes no difference to specify that twice.
Comment #20
jonathan1055 commentedComment #21
chr.fritschCool, what about a new SCMI release now? :)
Comment #22
jonathan1055 commentedYes very soon. I have one more bit of work to do on #3317999: Set publish_state fields to be hidden by default which really has to be in the next release.
Comment #23
vipin.mittal18@jonathan1055: As #3317999 has been fixed, now awaiting for D10 pre/stable release.
Comment #24
rajeshreeputraAwaiting for the release, thank you @jonathan1055.
Comment #25
jonathan1055 commentedThe last blocker was #3325208: Form fields should only be enabled if the entity type is moderatable which I only finished yesterday evening.
Comment #26
jonathan1055 commented@smustgrave has just done the release - SCMI 2.0.0-beta1