Problem/Motivation

Unable to download the module on Drupal 10 beta/rc version.

Steps to reproduce

1. Setup Drupal 10 rc version: composer create-project drupal/recommended-project:10.0.0-rc1@RC "install-dir"
2. Download module through composer: omposer require 'drupal/scheduler_content_moderation_integration:2.x-dev@dev'

Screenshot

scheduler_content_moderation_integration error

CommentFileSizeAuthor
scheduler download fail.png367.46 KBvipin.mittal18
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

vipin.mittal18 created an issue. See original summary.

smustgrave’s picture

Status: Needs work » Closed (won't fix)

So the MR is pointing at the 1.x branch. The plan is make 2.x be the D10 branch which we hope to have a beta release soon. thank you

ankitv18’s picture

Status: Closed (won't fix) » Needs work

Hi @smustgrave,
We need to remove "drupal/core": "^8.7.7 || ^9", from composer.json file for 2.x release and so that it is fully compatible for D10 release.

ankitv18’s picture

Assigned: Unassigned » ankitv18
ankitv18’s picture

Status: Needs work » Active

chr.fritsch made their first commit to this issue’s fork.

chr.fritsch’s picture

Status: Active » Needs review

MR is ready for review

jonathan1055’s picture

Thanks for the fixes @chr.fritsch

I thought that the D10 preparation had all been done in #3289476-14: Automated Drupal 10 compatibility fixes but I can see that we committed #3208882: Update SCMI to support scheduler 2.x entity plugins for media, etc which was not completely D10 ready, but which had missed the automatic fixes bot patch. So some of these changes in MR33 do need to be committed.

However I'm not sure we want to stop supporting D8 on the first SCMI 2.0 release. We should be able to keep D8 support for a while. Scheduler 2.0 will still support D8 so to help those sites who have not updated to D9 yet we should not cut them out of using SCMI 2.0

chr.fritsch’s picture

D8 is dead for a year now. Time to drop it

chr.fritsch’s picture

I brought back the D8 compatibility and ran the tests locally, because on d.o. it's not possible anymore to run D8 tests...

jonathan1055’s picture

Assigned: ankitv18 » Unassigned

Thanks chr.fritsch. Yes you are right that D8 tests can't be run on drupal.org, so to examine other possibilities I have opened #3324954: Drop Core 8.x compatibility on 2.x branch. Add testing at MAX_PHP so we can continue the discussion there.

jonathan1055’s picture

Tests passed at D9 and D10. Last commit puts back the explicit version dependencies in .info and composer.json. I think this is better than not to specify any version. Is that right?

chr.fritsch’s picture

If drupal/core is not specified in the composer.json, d.o.'s composer facade will add the version requirements from the info.yml to packagist. So I think it makes no difference to specify that twice.

jonathan1055’s picture

Issue summary: View changes
Status: Needs review » Fixed
chr.fritsch’s picture

Cool, what about a new SCMI release now? :)

jonathan1055’s picture

Yes very soon. I have one more bit of work to do on #3317999: Set publish_state fields to be hidden by default which really has to be in the next release.

vipin.mittal18’s picture

@jonathan1055: As #3317999 has been fixed, now awaiting for D10 pre/stable release.

rajeshreeputra’s picture

Awaiting for the release, thank you @jonathan1055.

jonathan1055’s picture

The last blocker was #3325208: Form fields should only be enabled if the entity type is moderatable which I only finished yesterday evening.

jonathan1055’s picture

@smustgrave has just done the release - SCMI 2.0.0-beta1

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.