Closed (works as designed)
Project:
Role help
Version:
7.x-1.x-dev
Component:
Code
Priority:
Major
Category:
Bug report
Assigned:
Reporter:
Created:
14 Jan 2016 at 18:56 UTC
Updated:
13 Mar 2016 at 07:57 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
aditya_anurag commentedComment #3
aditya_anurag commentedThanks for reporting the issue.
I think text formater is not required here so we can remove it. I created the patch please have a look.
Comment #4
krknth commentedchecking ..
Comment #5
rakesh.gectcrIf we don't need the text format, the patch is fine.
Comment #6
joachim commentedI'm not sure that removing the format is the right thing to do here.
Also, if you *did* want to remove this functionality, you'd need to also clean up code that uses the setting, such as:
Comment #7
n.kishorekumar commentedcode cleanup by removing all unused variable of role_help_format
Comment #8
n.kishorekumar commentedcode cleanup by removing all unused variable of role_help_format
Comment #9
n.kishorekumar commentedComment #10
n.kishorekumar commentedPlease dont use the previous patch.missed coding standards in that
Use this patch
code cleanup and by removing all unused variable of role_help_format and added interdiff file with this
Comment #11
joachim commented> I'm not sure that removing the format is the right thing to do here.
Could someone explain the reasoning for removing this functionality?
Comment #12
n.kishorekumar commented@joachim : I think #3 was mistaken. I updated the patch which can work with formatter.
Comment #13
imalabya@N.kishorekumar
$row[] = t('@name <em>(locked)</em>', array('@name' => $name)) . '<br><div class="description">' . check_markup($summary,variable_get('role_help_format')) . '</div>';Please Add a default value for the variable_get. Even it is not effecting the functionality it is good practice to have a fallback value when using variable_get.
Comment #14
n.kishorekumar commented@malabya Thanks for reviewing the patch
Added the fallback value in the variable_get
Comment #15
krknth commentedLet me clarify why we need text_format form field in the form.
@loopduplicate : The text_format form field showing up in the admin/config/people/role_help/ page
*I'm changing the title of the issue*
@aditya_anurag: Yes i agree, we might not require text_form field as it is just help text & we can simply show it as plain text. But let keep it as optional might be someone require it for design perspective.
@N.kishorekumar : Please check on help/roles page, its working as expected
But I think we need text format for other roles also (on role edit pages).
@Note : text_format not required for description of roles & it only shows on help/roles page.
Comment #16
krknth commentedTo avoid to confusion - lets add Summary text field in help/roles page. So it will be clear that the purpose of summary & help text fields.
Comment #17
krknth commentedReverting issue metadata to original
Comment #18
krknth commentedBetter to follow this issue #2686441: Standardize Summary, Help text fields for anonymous and authenticated roles..
I'm closing this issue because as per issue description it was working as designed.