Can't set maximum uses to unlimited [#758476]

When creating a new code, I am unable to set maximum uses to 0 (unlimited), the code just defaults to one use. Non-zero max uses work just fine.

Comment	File	Size	Author
#1	regcode_758476.patch	463 bytes	hadsie

Comments

hadsie commented 11 April 2010 at 16:04

Status	File	Size
new	regcode_758476.patch	463 bytes

I think this is caused because the code is running this when it saves to the database:
empty($code->maxuses) ? 1 : (int) $code->maxuses

empty will return TRUE if maxuses is 0. isset should be used instead. I've attached a patch that fixes the problem and is working for me.

aidanlis commented 17 April 2010 at 01:07

Status:

Needs review

» Fixed

Thanks for fixing this and sorry for the delay in replying.

1 May 2010 at 01:10

Status:

Fixed

» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.