Minor fixes for the module [#2384113]

Hi, this is look like a nice module but there are few fixes i felt that need to be done here:
1. Menu - the link for the ref debug page settings should under development but now it's just standing as it own menu item.
2. The setting 'Display debug info above page for entities' isn't working. I think it's redundant since people used to output like the devel page but it's not working any way.
3. I remove un-used variable, and minor code fixes.

Comment	File	Size	Author
	ref-debug-minor-fixes.patch	2.06 KB	RoySegall

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

RoySegall CreditAttribution: RoySegall commented 30 November 2014 at 09:04

Status:

Active

» Needs review

Comment #2

MiSc CreditAttribution: MiSc commented 1 December 2014 at 10:34

Thanks for testing, but I'm not sure of any of your three issues, could you attach screen dumps with your problems?

Comment #3

RoySegall CreditAttribution: RoySegall commented 1 December 2014 at 11:00

Yeah, i'll make some screen shots.

Comment #4

MiSc CreditAttribution: MiSc commented 2 December 2014 at 00:17

Status:

Needs review

» Postponed (maintainer needs more info)

Comment #5

dbazuin CreditAttribution: dbazuin commented 3 January 2015 at 12:44

Version:

» 7.x-1.x-dev

The display info above setting is not working for me either.
If it is redundant then the whole admin settings ar not necessary.

Adding package info would be a small improvement.
package = Development

Comment #6

MiSc CreditAttribution: MiSc commented 7 January 2015 at 11:02

dbazuin - could you please add info about your setup?

Comment #7

dbazuin CreditAttribution: dbazuin commented 14 January 2015 at 18:42

MiSc what would you like to know?

It does not seems to matter if I check or uncheck "The Display debug info above page for entities", the output is always above the page.
When I put a r($some_thing) in a module file en load a page I do get the output above.

The function "ref_debug_load" is only used in hook_menu().
I am not sure what your idea is with that construction.

Somehow it seems I get a output from ref_debug even if "ref_debug_load" is not used.
When I remove that function the result is exactly the same.

Comment #8

MiSc CreditAttribution: MiSc commented 28 February 2015 at 08:10

I think the problem lies in the description of it - what the settings means is that on a entity, and clicking the ref debug tab, debugging is rendered on the page or in the top, normal debugging in code is always on the top. Have I understand the issue correct?