Closed (fixed)
Project:
Redirect
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
15 Jan 2019 at 09:35 UTC
Updated:
23 Jul 2019 at 10:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
sergiu stici commentedHere is the patch, please review.
Comment #4
berdirWIP patch, does not include #2 as that isn't really what this issue is about, I'll merge that later or move to a different issue.
Comment #5
berdirProgress.
Comment #7
berdirMoving GlobalRedirectTest to a follow-up, that one is tough.
Comment #8
lendudecould just use
$this->getHttpClient():( but probably safer to do both? In case it runs longer than 1 second?
2 spaces! :D
And lots of uses of t() that can be removed, but that should probably not be done here
Comment #9
berdir1. Didn't know that method, updated.
2. I'm not sure why, but adding the wait on ajax somehow resulted in an exception, that's why I went with 1s... there's some pretty funky ajax going on that form, I'm not sure if something goes wrong if I call wait for ajax and there's actually no ajax call pending: "RuntimeException : Unable to complete AJAX request.". But at the same time, I have to wait, because apparently when I submit when the ajax request is still active, then the value of that form field is dropped o.0.
3. fixed.
Comment #10
lendudeAs discussed in slack:
The assertWaitOnAjaxRequest() weirdness might be the result from a 403 on the AJAX request in that scenario
Comment #11
berdirOk, that turned out to really be a bug, some paths can throw an access denied exception (not sure why a leading / would cause that, though).
Added a catch for that for now, that makes it work with a regular ajax wait.
Comment #12
berdirCommitted.
Comment #14
lendudeNice, real JS testing that uncovers bugs :)