Replace REQUEST_TIME with TimeService [#2933395]

Comment	File	Size	Author
#5	REQUEST_TIME-2933395-5.patch	1.55 KB	arunkumark
#2	REQUEST_TIME-2933395-2.patch	1.94 KB	sivaprasadc

Comment #1

28 December 2017 at 17:21

Sivaprasad C created an issue. See original summary.

Log in or register to post comments

Comment #2

sivaprasadc commented 28 December 2017 at 17:37

Assigned:

sivaprasadc

» Unassigned

Status	File	Size
new	REQUEST_TIME-2933395-2.patch	1.94 KB

Attaching the patch. Please review.

Log in or register to post comments

Comment #3

sivaprasadc commented 29 December 2017 at 06:44

Category:	Feature request	» Task
Status:	Active	» Needs review

Log in or register to post comments

Comment #4

29 December 2017 at 06:53

Status:

Needs review

» Needs work

The last submitted patch, 2: REQUEST_TIME-2933395-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Log in or register to post comments

Comment #5

arunkumark

Coimbatore

commented 8 January 2018 at 08:15

Status:

Needs work

» Needs review

Status	File	Size
new	REQUEST_TIME-2933395-5.patch	1.55 KB

I have re-rolled the patch to resolve the testing.

Log in or register to post comments

Comment #6

berdir

German

Switzerland

commented 23 January 2018 at 07:04

+++ b/redirect.generate.inc
@@ -139,14 +139,15 @@ function redirect_generate_batch_generate($num, array &$context) {
 
     if (mt_rand(0, 1)) {
-    $query = \Drupal::database();
-    $query->update('redirect')
-      ->fields(array(
-        'count' => mt_rand(1, 500),
-        'access' => mt_rand(REQUEST_TIME - 31536000, REQUEST_TIME),
-      ))
-      ->condition('rid', $redirect->id())
-      ->execute();
+      $request_time = \Drupal::time()->getRequestTime();
+      $query = \Drupal::database();

this code has never been ported from 7.x, those fields simply don't exist anymore.

Wondering if we should completely remove that file instead of doing some random paretial conversions when the while concept is completely different now.