Problem/Motivation

Ensure that module works with PHP8.0

Steps to reproduce

DrupalCI throws issues in dependencies

Proposed resolution

Ensure that tests run smoothly on DrupalCI with PHP8

Remaining tasks

Run a custom DrupalCI config with patches for test dependencies

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#4 3210980-4.diff1.11 KBtaran2l

Issue fork range-3210980

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Taran2L created an issue. See original summary.

Taran2L opened merge request !1

taran2l’s picture

taran2l
Primary language Ukrainian
Location Lviv
commented
Status: Active » Needs review
taran2l’s picture

taran2l
Primary language Ukrainian
Location Lviv
commented
StatusFileSize
new 3210980-4.diff1.11 KB

Yeah, MR testing cannot pick up test dependencies (sad)

taran2l’s picture

taran2l
Primary language Ukrainian
Location Lviv
commented
Related issues: +#3210977: PHP 8.0 compatibility, +#3208036: PHP 8.0 compatibility for Search API, +#3206793: Remove required parameter following optional parameter (PHP 8.0)

Alright, it (almost) works, but requires patches to the test dependencies:

See

I bet CCK won't be patched ever, thus the patch is in custom drupalci.yml, let's wait for others

taran2l’s picture

taran2l
Primary language Ukrainian
Location Lviv
commented
Title: PHP 8 compatibility » [PP-2] PHP 8 compatibility
Status: Needs review » Postponed
taran2l’s picture

taran2l
Primary language Ukrainian
Location Lviv
commented
Related issues: +#3207982: PHP 8.0 compatibility for Views 3

  • Taran2L committed fdd5698 on 7.x-1.x 
    Issue #3210980 by Taran2L: [PP-2] PHP 8 compatibility

Taran2L opened merge request !2

  • Taran2L committed 05a7c7f on 7.x-1.x 
    Issue #3210980 by Taran2L: PHP 8 compatibility [step 2]
taran2l’s picture

taran2l
Primary language Ukrainian
Location Lviv
commented
Title: [PP-2] PHP 8 compatibility » PHP 8 compatibility
Status: Postponed » Needs review

  • Taran2L committed e876da2 on 7.x-1.x 
    Issue #3210980 by Taran2L: PHP 8 compatibility [step 3]
taran2l’s picture

taran2l
Primary language Ukrainian
Location Lviv
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.